Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-4224: [Python] Support integration with pydata/sparse library #4990

Closed
wants to merge 3 commits into from
Closed

ARROW-4224: [Python] Support integration with pydata/sparse library #4990

wants to merge 3 commits into from

Conversation

rok
Copy link
Member

@rok rok commented Aug 1, 2019

This is to resolve ARROW-4224.

Please note this requires #4779 to be reviewed and merged first.

@rok rok changed the title ARROW-4223: [Python] Support integration with pydata/sparse library ARROW-4224: [Python] Support integration with pydata/sparse library Aug 1, 2019
@rok rok force-pushed the ARROW-4224 branch 4 times, most recently from 8690689 to 3a44693 Compare August 8, 2019 15:18
@rok rok mentioned this pull request Aug 8, 2019
Closed
@codecov-io
Copy link

codecov-io commented Aug 8, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@c024952). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4990   +/-   ##
=========================================
  Coverage          ?   78.18%           
=========================================
  Files             ?       59           
  Lines             ?     4562           
  Branches          ?        0           
=========================================
  Hits              ?     3567           
  Misses            ?      995           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c024952...7354444. Read the comment docs.

@mrkn
Copy link
Member

mrkn commented Aug 9, 2019

This looks good to me.

@rok rok force-pushed the ARROW-4224 branch 2 times, most recently from 274ec97 to 1461e7d Compare August 23, 2019 11:15
@rok rok force-pushed the ARROW-4224 branch 3 times, most recently from 4405031 to 7328fa0 Compare September 3, 2019 18:23
@rok rok force-pushed the ARROW-4224 branch 2 times, most recently from 6ce4a1f to 3d4ba7e Compare September 14, 2019 01:34
@rok rok force-pushed the ARROW-4224 branch 3 times, most recently from e2ad4c9 to 48629dd Compare October 1, 2019 15:52
pitrou
pitrou requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments below. Please be careful not to duplicate code everywhere.

cpp/src/arrow/python/serialize.h Outdated Show resolved Hide resolved
cpp/src/arrow/python/serialize.cc Outdated Show resolved Hide resolved
python/pyarrow/tests/test_serialization.py Outdated Show resolved Hide resolved
python/pyarrow/tests/test_serialization.py Outdated Show resolved Hide resolved
python/pyarrow/tests/test_serialization.py Outdated Show resolved Hide resolved
cpp/src/arrow/ipc/reader.cc Outdated Show resolved Hide resolved
cpp/src/arrow/ipc/reader.cc Outdated Show resolved Hide resolved
@mrkn mrkn mentioned this pull request Oct 8, 2019
Closed
@rok
Copy link
Member Author

rok commented Oct 8, 2019 •
edited

@mrkn @pitrou - please note the SparseTensor serialization here is the same as in #4779. This PR is rebased on top of #4779 and pydata/sparse specific python code is added.
I propose we continue the discussion under #4779. Sorry for the inconvenience.

@pitrou
Copy link
Member

pitrou commented Oct 16, 2019

Now that @mrkn pushed some commits here, should this PR be considered instead of #4779?

@pitrou
Copy link
Member

pitrou commented Oct 16, 2019

Also this may need rebasing for the sparse tensor naming fixes.

@rok
Copy link
Member Author

rok commented Oct 16, 2019

Now that @mrkn pushed some commits here, should this PR be considered instead of #4779?

I already moved @mrkn's commits to #4779 and rebased it. I'm ok with either PR, but slightly prefer #4779 as there's a long discussion already there.

@rok
Copy link
Member Author

rok commented Oct 16, 2019

Rebased.

@rok
Copy link
Member Author

rok commented Oct 16, 2019

Also this may need rebasing for the sparse tensor naming fixes.

Will do once #5605 is merged.

@rok rok force-pushed the ARROW-4224 branch 2 times, most recently from 5a5cc5a to 7354444 Compare October 22, 2019 14:07
@rok rok force-pushed the ARROW-4224 branch 3 times, most recently from a1ee924 to 16be415 Compare November 13, 2019 09:13
@rok
Copy link
Member Author

rok commented Nov 13, 2019 •
edited

@pitrou after merging #4779 this is greatly simplified.

@pitrou
Copy link
Member

pitrou commented Nov 13, 2019

Cool! Is this ready for review?

@rok
Copy link
Member Author

rok commented Nov 13, 2019

Cool! Is this ready for review?

Yeah, go for it. :)

pitrou
pitrou requested changes Nov 13, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two comments.

python/pyarrow/tensor.pxi Outdated Show resolved Hide resolved
python/pyarrow/tests/test_sparse_tensor.py Show resolved Hide resolved
@pitrou pitrou closed this in d286edb Nov 13, 2019
@rok
Copy link
Member Author

rok commented Nov 13, 2019

Great! Thanks @pitrou and @mrkn!

@mitar
Copy link
Contributor

mitar commented Nov 13, 2019

Awesome. Thanks @rok!

@asfimport asfimport mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkn mrkn mrkn left review comments

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rok @codecov-io @mrkn @pitrou @mitar