Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6109: [Integration] Docker image for integration testing can't be built on windows #4992

Closed
wants to merge 1 commit into from

Conversation

paddyhoran
Copy link
Contributor

Git for windows checks files out with windows line endings and converts them back before checking them in.

This causes issues in the bash scripts (which are copied from the windows file system into the image) we use to build the "arrow_integration_xenial_base" image when using docker on windows.

@kszucs PTAL. I'm not sure if this Dockerfile is used as part of CI (and so CI will test that the changes don't break building the image on other platforms)?

@paddyhoran paddyhoran requested a review from kszucs August 2, 2019 02:29
@paddyhoran paddyhoran changed the title ARROW-6109: [Integration] Updates Dockerfile to convert windows line endings. ARROW-6109: [Integration] Docker image for integration testing can't be built on windows Aug 2, 2019
@kszucs
Copy link
Member

kszucs commented Aug 13, 2019

Hey @paddyhoran! I'm not sure that we use this docker file anymore. Regarding the line endings, it is pretty sad that docker now win has not resolved it yet docker/for-win#1340

On short term this could work, but on long term we might create a custom script runner which does the conversion on the fly and we can reuse it across multiple dockerfiles.

@paddyhoran
Copy link
Contributor Author

Yea it looks like the one described here isn't used either probably.

As there is an upstream issue in docker and it would add a lot of boilerplate I'll close this PR/issue, I can add it manually in the interim (it seems I'm the only one on windows anyway :)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants