Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6005: [C++] extend GetRecordBatchReader test to cover reading a single row group #5012

Closed
wants to merge 1 commit into from

Conversation

hatemhelal
Copy link
Contributor

@hatemhelal hatemhelal commented Aug 5, 2019

This adds a basic unittest for row group selection with the GetRecordBatchReader API.

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #5012 into master will increase coverage by 1.85%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5012      +/-   ##
==========================================
+ Coverage   87.32%   89.18%   +1.85%     
==========================================
  Files         895      727     -168     
  Lines      119946   102952   -16994     
  Branches     1418        0    -1418     
==========================================
- Hits       104748    91821   -12927     
+ Misses      14836    11131    -3705     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/parquet/arrow/arrow-reader-writer-test.cc 93.73% <100%> (+0.05%) ⬆️
cpp/src/arrow/array-binary-test.cc 100% <0%> (ø) ⬆️
cpp/src/arrow/array/builder_base.h 92.5% <0%> (ø) ⬆️
go/arrow/ipc/writer.go
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
... and 461 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0423a...c1ccb88. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 6c7f2ae Aug 8, 2019
pprudhvi pushed a commit to pprudhvi/arrow that referenced this pull request Aug 11, 2019
… single row group

This adds a basic unittest for row group selection with the `GetRecordBatchReader` API.

Closes apache#5012 from hatemhelal/arrow-6005 and squashes the following commits:

c1ccb88 <Hatem Helal> extend GetRecordBatchReader test to cover reading a single row group

Authored-by: Hatem Helal <hhelal@mathworks.com>
Signed-off-by: Wes McKinney <wesm+git@apache.org>
@hatemhelal hatemhelal deleted the arrow-6005 branch August 16, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants