Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6175: [Java] Fix MapVector#getMinorType and extend AbstractContainerVector addOrGet complex vector API #5043

Closed
wants to merge 1 commit into from

Conversation

tianchen92
Copy link
Contributor

Related to ARROW-6175.

i. Currently MapVector#getMinorType extends ListVector which returns the wrong MinorType.
ii. AbstractContainerVector now only has addOrGetList, addOrGetUnion, addOrGetStruct which not support all complex type like MapVector and FixedSizeListVector.

@codecov-io
Copy link

Codecov Report

Merging #5043 into master will increase coverage by 2.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5043      +/-   ##
==========================================
+ Coverage   87.57%   89.68%    +2.1%     
==========================================
  Files        1008      670     -338     
  Lines      143790    99342   -44448     
  Branches     1418        0    -1418     
==========================================
- Hits       125926    89091   -36835     
+ Misses      17502    10251    -7251     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
cpp/src/arrow/util/thread-pool-test.cc 97.66% <0%> (-0.94%) ⬇️
r/src/recordbatch.cpp
r/R/Table.R
js/src/util/fn.ts
go/arrow/array/bufferbuilder.go
r/src/symbols.cpp
rust/datafusion/src/execution/projection.rs
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
... and 331 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062cc70...110aa84. Read the comment docs.

@emkornfield
Copy link
Contributor

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants