ARROW-5134: [R][CI] Run nightly tests against multiple R versions #5121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers install them (they're not needed for package checks and don't enhance the use of the package itself
Codecov Report
@@ Coverage Diff @@
## master #5121 +/- ##
=========================================
Coverage ? 75.26%
=========================================
Files ? 57
Lines ? 3619
Branches ? 0
=========================================
Hits ? 2724
Misses ? 895
Partials ? 0
Continue to review full report at Codecov.
|
|
Are you still doing any work on this or can it be merged? |
|
This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly R builds on multiple R versions are now running on https://github.com/ursa-labs/arrow-r-nightly on Travis and Appveyor. https://issues.apache.org/jira/browse/ARROW-6258 facilitated the macOS portion of this; Windows required no changes to apache/arrow to set up. As a side benefit of the Travis/Appveyor setup, binary packages for macOS and Windows are being built and pushed to https://dl.bintray.com/ursalabs/arrow-r, which R users can use as package repository.
This patch fixes one line of R code (offending R change here) to enable passing builds going back to R 3.2. That's 6 total R versions supported with binary builds: 3.2 - 3.6, plus R-devel (to be 3.7) on Windows. It also adds some badges to the R README indicating status of the nightly builds, plus a note pointing intrepid users to the (very unofficial) binaries on Bintray.