Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6046: [C++] Do not write excess varbinary offsets in IPC messages from sliced BinaryArray #5126

Closed
wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Aug 19, 2019

Even when creating very small slices of a large array starting from offset 0, we were writing the entire offsets buffer unnecessarily.

@codecov-io
Copy link

Codecov Report

Merging #5126 into master will decrease coverage by 22.06%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5126       +/-   ##
===========================================
- Coverage   87.62%   65.56%   -22.07%     
===========================================
  Files        1014      552      -462     
  Lines      145892    70712    -75180     
  Branches     1437        0     -1437     
===========================================
- Hits       127843    46359    -81484     
- Misses      17687    24353     +6666     
+ Partials      362        0      -362
Impacted Files Coverage Δ
cpp/src/arrow/ipc/writer.cc 75.66% <50%> (-17.47%) ⬇️
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/date_utils.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.cc 0% <0%> (-100%) ⬇️
cpp/src/gandiva/decimal_type_util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/filesystem/util_internal.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/logical_type.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/basic_decimal_scalar.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/kernels/boolean.cc 0% <0%> (-100%) ⬇️
... and 704 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747b476...f3282f4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants