ARROW-6174: [C++] Validate chunks in ChunkedArray::Validate. Fix validation of sliced ListArray, values null checks #5148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array::Slice
, the child values buffer actually is not modified (maybe it should be?) so this invariant is broken. The main thing that matters is that the values buffer is at least as large as the last offset.Otherwise I think that validating chunks in
ChunkedArray::Validate
is a good idea.