Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6325: [Python] fix conversion of strided boolean arrays #5176

Conversation

jorisvandenbossche
Copy link
Member

https://issues.apache.org/jira/browse/ARROW-6325

Needed to flip the order of the strided / boolean check, as the strided code path was not specialized for boolean values, and the boolean code path already handled strided arrays fine.

@codecov-io
Copy link

Codecov Report

Merging #5176 into master will increase coverage by 1.88%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5176      +/-   ##
==========================================
+ Coverage   87.36%   89.24%   +1.88%     
==========================================
  Files         909      739     -170     
  Lines      122252   105417   -16835     
  Branches     1437        0    -1437     
==========================================
- Hits       106807    94081   -12726     
+ Misses      15083    11336    -3747     
+ Partials      362        0     -362
Impacted Files Coverage Δ
python/pyarrow/tests/test_pandas.py 95.19% <100%> (ø)
python/pyarrow/tests/test_array.py 95.36% <100%> (ø)
cpp/src/arrow/python/numpy_to_arrow.cc 95.78% <100%> (ø)
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
... and 463 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbaf72...2c0ca6a. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants