Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6383: [Java] Report outstanding child allocators on close #5227

Closed
wants to merge 2 commits into from

Conversation

pravindra
Copy link
Contributor

  • this was happening in debug code, now added in non-debug

- this was happening in debug code, now added in non-debug
@pitrou pitrou changed the title ARROW-6383: report outstanding child allocators on close ARROW-6383: [Java] Report outstanding child allocators on close Aug 29, 2019
@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #5227 into master will increase coverage by 1.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5227      +/-   ##
==========================================
+ Coverage   87.67%   89.67%   +1.99%     
==========================================
  Files        1025      693     -332     
  Lines      147030   104108   -42922     
  Branches     1437        0    -1437     
==========================================
- Hits       128915    93357   -35558     
+ Misses      17753    10751    -7002     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/gandiva/function_holder_registry.h 75% <0%> (-15%) ⬇️
cpp/src/arrow/filesystem/filesystem.cc 80% <0%> (-6.8%) ⬇️
cpp/src/gandiva/gdv_function_stubs.cc 89.6% <0%> (-4.32%) ⬇️
cpp/src/arrow/json/converter.cc 90.05% <0%> (-1.76%) ⬇️
cpp/src/arrow/json/chunked_builder.cc 79.91% <0%> (-1.68%) ⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c 72.39% <0%> (-1.21%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
python/pyarrow/types.pxi 68.04% <0%> (-0.61%) ⬇️
cpp/src/arrow/type.cc 94.02% <0%> (-0.6%) ⬇️
cpp/src/arrow/flight/server.cc 88.28% <0%> (-0.43%) ⬇️
... and 384 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bc63c...4898a06. Read the comment docs.

Copy link
Contributor

@liyafan82 liyafan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pravindra
Copy link
Contributor Author

thanks for the review @liyafan82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants