Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-6387: [Archery] Errors with make #5234

Closed
wants to merge 1 commit into from
Closed

ARROW-6387: [Archery] Errors with make #5234

wants to merge 1 commit into from

Conversation

ozars
Copy link
Contributor

@ozars ozars commented Aug 29, 2019

cmake --build is called instead of a direct call to generator program (make, ninja etc.).

@ozars
Copy link
Contributor Author

ozars commented Aug 29, 2019

Heh. Just realized this enables parallel builds in archery for cmake 3.12+ as a side effect: CMAKE_BUILD_PARALLEL_LEVEL=8 archery --debug benchmark run

fsaintjacques
fsaintjacques approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@fsaintjacques fsaintjacques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, tested locally and it worked.

@ozars ozars deleted the arrow-6387 branch September 9, 2019 16:24
@asfimport asfimport mentioned this pull request Aug 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsaintjacques fsaintjacques fsaintjacques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ozars @fsaintjacques