Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6406: [C++] Fix jemalloc URL for offline build in thirdparty/versions.txt #5246

Closed
wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Aug 31, 2019

The archive URL is not the released tarball and did not work with jemalloc_ep

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

Codecov Report

Merging #5246 into master will increase coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5246      +/-   ##
==========================================
+ Coverage   87.63%   89.18%   +1.55%     
==========================================
  Files        1033      750     -283     
  Lines      148630   107752   -40878     
  Branches     1437        0    -1437     
==========================================
- Hits       130249    96103   -34146     
+ Misses      18019    11649    -6370     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/arrow/filesystem/s3_internal.h 95.12% <0%> (-4.88%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
rust/parquet/src/arrow/converter.rs
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2164e3b...0c6c454. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #5246 into master will increase coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5246      +/-   ##
==========================================
+ Coverage   87.63%   89.18%   +1.55%     
==========================================
  Files        1033      750     -283     
  Lines      148630   107752   -40878     
  Branches     1437        0    -1437     
==========================================
- Hits       130249    96103   -34146     
+ Misses      18019    11649    -6370     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/arrow/filesystem/s3_internal.h 95.12% <0%> (-4.88%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
rust/parquet/src/arrow/converter.rs
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2164e3b...0c6c454. Read the comment docs.

@kou kou closed this in 7d63dfe Aug 31, 2019
@wesm wesm deleted the ARROW-6406 branch August 31, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants