ARROW-6418: [C++][Plasma] Remove cmake project directive for plasma #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting plasma into a separate project prevents it from being
exported to ArrowTargets.cmake, because targets are added to the
export sets based on ${PROJECT_NAME}, but the plasma-targets are
neither exported to the build tree nor installed.
An alternative fix for this is to handle the plasma-targets similar
to the arrow-targets, but I can't see a benefit for that approach
and it would require users to take additional steps.
Codecov Report
@@ Coverage Diff @@
## master #5249 +/- ##
==========================================
+ Coverage 87.65% 89.21% +1.55%
==========================================
Files 1033 750 -283
Lines 148767 107803 -40964
Branches 1437 0 -1437
==========================================
- Hits 130397 96173 -34224
+ Misses 18008 11630 -6378
+ Partials 362 0 -362Continue to review full report at Codecov.
|
|
Could you open an issue on JIRA https://issues.apache.org/jira/projects/ARROW/issues and prepend "ARROW-${JIRA_ISSUE_ID}: [C++][Plasma] " to the subject of this pull request? https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches |
tobim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting plasma into a separate project prevents it from being exported to ArrowTargets.cmake, because targets are added to the export sets based on ${PROJECT_NAME}, but the plasma-targets are neither exported to the build tree nor installed.
An alternative fix for this is to handle the plasma-targets similar to the arrow-targets, but I can't see a benefit for that approach and it would require users to take additional steps.