Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6300: [C++] Add Abort() method to streams #5274

Closed
wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 4, 2019

This is a quick-close method that does not guarantee it will flush any pending data,
just deallocate ressources held up by the stream.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@26f631f). Click here to learn what that means.
The diff coverage is 63.02%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5274   +/-   ##
=========================================
  Coverage          ?   89.18%           
=========================================
  Files             ?      750           
  Lines             ?   108228           
  Branches          ?        0           
=========================================
  Hits              ?    96528           
  Misses            ?    11700           
  Partials          ?        0
Impacted Files Coverage Δ
cpp/src/arrow/io/memory.h 100% <ø> (ø)
cpp/src/arrow/io/interfaces.h 90% <ø> (ø)
cpp/src/arrow/io/compressed.h 100% <ø> (ø)
cpp/src/arrow/python/io.h 100% <ø> (ø)
cpp/src/arrow/filesystem/s3_internal.h 100% <ø> (ø)
python/pyarrow/io.pxi 72.18% <ø> (ø)
cpp/src/arrow/filesystem/mockfs.cc 94.64% <0%> (ø)
cpp/src/arrow/io/file.cc 97.66% <100%> (ø)
cpp/src/arrow/io/memory.cc 90.47% <100%> (ø)
cpp/src/arrow/filesystem/s3fs_test.cc 99.23% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f631f...b9cde7f. Read the comment docs.

cpp/src/arrow/python/io.cc Outdated Show resolved Hide resolved
This is a quick-close method that does not guarantee it will flush any pending data,
just deallocate ressources held up by the stream.
@wesm wesm closed this in dd29b04 Sep 10, 2019
@pitrou pitrou deleted the ARROW-6300-stream-abort branch September 10, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants