ARROW-6464: [Java] Refactor FixedSizeListVector#splitAndTransfer with slice API

[tianchen92]

Related to ARROW-6464.

Currently FixedSizeListVector#splitAndTransfer actually use copyValueSafe which has memory copy, we should use slice API instead.
Meanwhile, splitAndTransfer in all classes should position index check at beginning.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@d2be6a5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5293   +/-   ##
=========================================
  Coverage          ?   89.81%           
=========================================
  Files             ?      697           
  Lines             ?   105908           
  Branches          ?        0           
=========================================
  Hits              ?    95116           
  Misses            ?    10792           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2be6a5...e612059. Read the comment docs.

[emkornfield]

@jacques-n where you going to take another look at this?

[wesm]

@jacques-n ping?

[siddharthteotia]

LGTM. However, I would suggest to add as many tests as possible to cover exhaustive set of corner cases with validity transfer. In the past there were so many boundary cases that were found as bugs and were incredibly hard to debug/reproduce. It would be great if you can do that in this or follow-up PR.

[tianchen92]

LFGTM. However, I would suggest to add as many tests as possible to cover exhaustive set of corner cases with validity transfer. In the past there were so many boundary cases that were found as bugs and were incredibly hard to debug/reproduce. It would be great if you can do that in this or follow-up PR.

Sure, I could do this in a follow-up PR, thanks!

[siddharthteotia]

LFGTM. However, I would suggest to add as many tests as possible to cover exhaustive set of corner cases with validity transfer. In the past there were so many boundary cases that were found as bugs and were incredibly hard to debug/reproduce. It would be great if you can do that in this or follow-up PR.

Sure, I could do this in a follow-up PR, thanks!

Sorry LFGTM was a typo.