ARROW-6492: [Python] Handle pandas_metadata created by fastparquet with missing field_name #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th missing field_name
pitrou
changed the title
wesm
approved these changes
Sep 9, 2019
|
Merging. Appveyor only failed on account of the googletest_ep flakiness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARROW-6492
In our compat code, we have special cases for dealing with missing
field_namekeys (as arrow did not write those up to 0.8), but that also dealt with fastparquet compat. However, this code did not cover the case where the index was stored as metadata-only, which now happens in fastparquet (because fastparquet adopted the syntax we use to store index metadata).