ARROW-6525: [C++] Avoid aborting in CloseFromDestructor() #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
approved these changes
Sep 11, 2019
| #else | ||
| std::stringstream ss; | ||
| ss << "When destroying file of type " << file_type << ": " << st.message(); | ||
| ARROW_LOG(FATAL) << st.WithMessage(ss.str()); |
There was a problem hiding this comment.
(different PR, probably) Seems like WithMessage could benefit from a string builder parameter list like the Status factories'
There was a problem hiding this comment.
Perhaps. I'll let you open a JIRA :-)
There was a problem hiding this comment.
In release mode, only log an error. Still abort in debug mode to point out any issue in testing conditions.
pitrou
force-pushed
the
ARROW-6525-close-crash
branch
from
00ea669
to
65c4744
Compare
|
Rebased. |
pprudhvi
pushed a commit
to pprudhvi/arrow
that referenced
this pull request
Sep 16, 2019
In release mode, only log an error. Still abort in debug mode to point out any issue in testing conditions. Closes apache#5352 from pitrou/ARROW-6525-close-crash and squashes the following commits: 65c4744 <Antoine Pitrou> ARROW-6525: Avoid aborting in CloseFromDestructor() Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release mode, only log an error. Still abort in debug mode to point out
any issue in testing conditions.