ARROW-6581: [C++] Fix fuzzit job submission

[pitrou]

Also make it faster (we don't need Gandiva here).

[pitrou]

@yevgenypats

[pitrou]

@kszucs How do I run the crossbow fuzzit build here?

[pitrou]

@ursabot crossbow submit -g fuzzit

[ursabot]

Invalid value for "--group" / "-g": invalid choice: fuzzit. (choose from docker, integration, cpp-python, conda, wheel, linux, gandiva, nightly)

[pitrou]

@ursabot crossbow submit docker-cpp-fuzzit

[ursabot]

AMD64 Conda Crossbow Submit (#62855) builder has been succeeded.

Revision: 1306f15

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-194

Task	Status
docker-cpp-fuzzit

[yevgenypats]

this is also no longer necessary. go to https://app.fuzzit.dev/orgs/apache-arrow/settings and copy the new API Key to crossbow environment variables (I don't have access to this)

[pitrou]

But we'd like the docker-compose setup to be runnable from a local machine, I think.

[yevgenypats]

so there are two workflows fuzzing and regression.

fuzzing usually should only run from the CI when you push new code to master as this update the fuzzer on Fuzzit servers.

Regression is currently not enabled as far as I can see in this project. to enable regression you need to run the same ./fuzzit create job .... but with --type local-regression. this you can run from local machine as well and you don't need an api key for that at all.

To setup the regression in the CI you want to run it on every pull-request or even every commit. the fuzzing workflow should be called only on new pushed to master. I'm not sure how to do it with crossbow but I guess it shouldn't be too complicated.

(Hope it wasn't too confusing:))

[pitrou]

@kszucs How would we create an environment variable in crossbow?

[kszucs]

I think it would be better to have a separate docker-compose entries for the two fuzzit jobs.

  fuzzit:
    image: arrow:fuzzit
    build:
      context: .
      dockerfile: dev/fuzzit/Dockerfile
    environment:
      CI_ARROW_SHA: ${CI_ARROW_SHA}
      CI_ARROW_BRANCH: ${CI_ARROW_BRANCH}
    volumes: *ubuntu-volumes

  fuzzit-regression:
    image: arrow:fuzzit
    build:
      context: .
      dockerfile: dev/fuzzit/Dockerfile
    environment:
      CI_ARROW_SHA: ${CI_ARROW_SHA}
      CI_ARROW_BRANCH: ${CI_ARROW_BRANCH}
      # arbitrary env variables
    volumes: *ubuntu-volumes

Then we can run docker-compose run fuzzit and docker-compose run fuzzit-regression locally. After that we can setup specific crossbow tasks to run either one or both of them.

[pitrou]

@yevgenypats I have failed jobs with no logs at https://app.fuzzit.dev/orgs/apache-arrow/targets/arrow-ipc-fuzzing. For example https://app.fuzzit.dev/orgs/apache-arrow/targets/arrow-ipc-fuzzing/93zO2yTOpXN1VMyB4IAk

[pitrou]

Also, local regression job doesn't seem to work from a Docker container:

+ ./fuzzit create job --type local-regression --host bionic-llvm7 --revision --branch apache-arrow/arrow-ipc-fuzzing ./relwithdebinfo/out/fuzzer.tar.gz
2019/09/23 16:38:36 FUZZIT_API_KEY is not set. continue with public auth...
2019/09/23 16:38:36 Creating job...
2019/09/23 16:38:36 Pulling container bionic-llvm7
2019/09/23 16:38:36 Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

[yevgenypats]

@pitrou can you retry now, you hit a bug that I already fixed but look like the fix did not propagate to your account, should work now.

Regarding regression - Yes because regression spawns a docker so it will have a reproducible environment. If you want to run it from docker you need to mount the docker socket like here for example https://github.com/envoyproxy/envoy/pull/7509/files#diff-1dea4de506864476f95ae5a444472fe1R26

I created a fuzzing job and look like it works now https://app.fuzzit.dev/orgs/apache-arrow/targets/arrow-ipc-fuzzing/oRj7teBuJbxHAQhVPMNe

[pitrou]

@ursabot crossbow submit docker-cpp-fuzzit

[ursabot]

AMD64 Conda Crossbow Submit (#64665) builder has been succeeded.

Revision: 2628a74

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-216

Task	Status
docker-cpp-fuzzit

[yevgenypats]

@pitrou can you also update the CLI to v2.4.56 (I fixed a bug related to the bionic-llvm7 docker you use - this only affects regression)

[pitrou]

The script uses "latest", so it shouldn't need an update?

[yevgenypats]

Ah cool. Yes that's right.

…

On Mon, Sep 23, 2019, 1:30 PM Antoine Pitrou ***@***.***> wrote: The script uses "latest", so it shouldn't need an update? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5407?email_source=notifications&email_token=AD52CDWBIZHOM6MYP7JQO2TQLD4M7A5CNFSM4IXQ2O62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7LUOPY#issuecomment-534202175>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD52CDRJ6IXTEKCXX5UERJ3QLD4M7ANCNFSM4IXQ2O6Q> .

[pitrou]

@kszucs Do you think this is ok to merge?

[pitrou]

@kszucs Ping.

[kszucs]

Seems so, reviewing.

[kszucs]

R build failure is unrelated. We'll be able to set the required environment variables in the crossbow template file using {{ arrow.branch }} and {{ arrow.head }} (which is the head commit's SHA) jinja variables.

[kszucs]

LGTM

[kszucs]

We'll need a follow-up PR to add the crossbow tasks.