ARROW-6721: [JAVA] Avro adapter benchmark only runs once in JMH #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
approved these changes
Oct 4, 2019
|
We should try to rerun the failed job to make sure the timeout doesn't repeat |
|
build passed, seems previous failure is unrelated. |
|
+1, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6721.
The current AvroAdapterBenchmark actually only run once during JMH evaluation, since the decoder was consumed for the first time and the follow-up invokes will directly return.
To solve this, we use BinaryDecoder explicitly in benchmark and reset its inner stream first when the test method is invoked.