ARROW-6762: [C++] Support reading JSON files with no newline at end #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
force-pushed
the
ARROW-6762-json-parser-trailing-newline
branch
from
a3498d7
to
71c05d8
Compare
|
@ursabot build |
bkietz
requested changes
Oct 2, 2019
There was a problem hiding this comment.
This seems fine, just a few nits.
I don't think there is a lifetime issue if ChunkedArrayBuilder::Finish() is called before the builder is destroyed. It calls TaskGroup::Finish(), so all tasks in any other threads with a reference to the builder will terminate. This is the case in TableReader::Read, for example. Is there some use case for running a ChunkedArrayBuilder in a task group but never calling finish on it?
I had some actual crashes when adding the tests. The main situation is when the reader exits early - for example because chunking fails, but I think it may also happen if readahead fails (think I/O or decompression error). |
Also fix some lifetime issues in parallel mode, and add tests.
pitrou
force-pushed
the
ARROW-6762-json-parser-trailing-newline
branch
from
71c05d8
to
562783d
Compare
bkietz
approved these changes
Oct 3, 2019
kszucs
pushed a commit
that referenced
this pull request
Oct 5, 2019
Also fix some lifetime issues in parallel mode, and add tests. Closes #5564 from pitrou/ARROW-6762-json-parser-trailing-newline and squashes the following commits: 562783d <Antoine Pitrou> ARROW-6762: Support reading JSON files with no newline at end Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
Also fix some lifetime issues in parallel mode, and add tests. Closes apache#5564 from pitrou/ARROW-6762-json-parser-trailing-newline and squashes the following commits: 562783d <Antoine Pitrou> ARROW-6762: Support reading JSON files with no newline at end Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
Also fix some lifetime issues in parallel mode, and add tests. Closes apache#5564 from pitrou/ARROW-6762-json-parser-trailing-newline and squashes the following commits: 562783d <Antoine Pitrou> ARROW-6762: Support reading JSON files with no newline at end Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Oct 21, 2019
Also fix some lifetime issues in parallel mode, and add tests. Closes apache#5564 from pitrou/ARROW-6762-json-parser-trailing-newline and squashes the following commits: 562783d <Antoine Pitrou> ARROW-6762: Support reading JSON files with no newline at end Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix some lifetime issues in parallel mode, and add tests.