Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6808: [Ruby] Ensure requiring suitable MSYS2 package #5703

Closed
wants to merge 2 commits into from

Conversation

kou
Copy link
Member

@kou kou commented Oct 19, 2019

No description provided.

@github-actions
Copy link

Normally, "mingw-w64-i686-arrow>=NEXT_VERSION" doesn't install anything.
@codecov-io
Copy link

Codecov Report

Merging #5703 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
- Coverage   88.94%   88.93%   -0.01%     
==========================================
  Files         989      989              
  Lines      134526   134526              
  Branches     1501     1501              
==========================================
- Hits       119651   119645       -6     
- Misses      14510    14516       +6     
  Partials      365      365
Impacted Files Coverage Δ
cpp/src/arrow/filesystem/s3_internal.h 90.74% <0%> (-3.71%) ⬇️
cpp/src/arrow/csv/column_builder.cc 95.54% <0%> (-1.49%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 70.75% <0%> (-0.95%) ⬇️
python/pyarrow/tests/test_parquet.py 95.3% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d923462...47360c4. Read the comment docs.

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kszucs kszucs closed this in 2771140 Oct 21, 2019
@kou kou deleted the ruby-msys-version branch October 22, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants