ARROW-7195: [Ruby] Improve #filter, #take, and #is_in #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiro615
force-pushed
the
ruby-improve-filter-take-is-in
branch
from
d6464a5
to
e30406d
Compare
kou
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
+1
Thanks. I've pushed some changes:
- Use "generic" instead of "array" for generic method.
- Add support for
Arrow::Array#filter(Arrow::ChunkedArray). (It should be implemented in C++ in the future.) - Move all
requires for Red Arrow toloader.rb. - Add support for
#is_in(Array)for parameterized typed array such asArrow::TimestampArray.
@shiro615 Could you check my changes?
|
Thank you so much. I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for the argument of the following functions.