Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-1712: [C++] Stop using deprecated APIs in examples #5992

Closed
wants to merge 2 commits into from
Closed

PARQUET-1712: [C++] Stop using deprecated APIs in examples #5992

wants to merge 2 commits into from

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Dec 9, 2019

Some Status-returning APIs used in example files have been deprecated recently at 6758b24.

@mrkn mrkn changed the title [Parquet] Stop using deprecated APIs in examples PARQUET-1712: [C++] Stop using deprecated APIs in examples Dec 9, 2019
@mrkn mrkn requested a review from wesm December 9, 2019 07:29
@github-actions
Copy link

github-actions bot commented Dec 9, 2019

https://issues.apache.org/jira/browse/PARQUET-1712

@mrkn mrkn requested review from kou and pitrou and removed request for wesm December 9, 2019 07:47
kou
kou approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Can we add -DPARQUET_BUILD_EXECUTABLES=ON to detect this by CI?

wesm
wesm reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine. Agree that building these somewhere in CI would help keep them clean / working

@gallushi gallushi mentioned this pull request Dec 9, 2019
Closed
@kszucs kszucs closed this in fcefd3d Dec 9, 2019
@gallushi gallushi mentioned this pull request Dec 10, 2019
Closed
pitrou pushed a commit that referenced this pull request Dec 11, 2019
@gallushi @pitrou
PARQUET-1715:[C++] Add the Parquet code samples to CI + Refactor Parq…
68903ac 
…uet Encryption Samples

A small refix for #5992

Closes #6007 from gallushi/master and squashes the following commits:

0ce249e <Gal Lushi> small fix in the CMakeLists.txt of the parquet samples
d9aa734 <Gal Lushi> Refactor the Parquet Encryption code samples to use Result<T> APIs + Build the Parquet code samples in CI

Authored-by: Gal Lushi <gallushi@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@mrkn mrkn deleted the PARQUET-1712 branch December 12, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm left review comments

@kou kou kou approved these changes

@kszucs kszucs kszucs approved these changes

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrkn @kou @wesm @kszucs