Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-6902: [C++][Compute] Add String/Binary support to Compare kernel #6034

Closed
wants to merge 4 commits into from

Conversation

bkietz
Copy link
Member

@bkietz bkietz commented Dec 13, 2019

No description provided.

@github-actions
Copy link

@bkietz bkietz force-pushed the 6902-Add-String-Binary-support branch 2 times, most recently from 4e180e6 to bd6139c Compare December 14, 2019 22:19
@bkietz bkietz marked this pull request as ready for review December 16, 2019 14:58
@apache apache deleted a comment from ursabot Dec 16, 2019
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Overall, LGTM on the principle.

cpp/src/arrow/compute/kernels/compare.cc Show resolved Hide resolved
cpp/src/arrow/compute/kernels/compare.h Show resolved Hide resolved
cpp/src/arrow/compute/kernels/compare.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/kernels/compare.cc Show resolved Hide resolved
cpp/src/arrow/compute/kernels/compare.cc Outdated Show resolved Hide resolved
@bkietz bkietz force-pushed the 6902-Add-String-Binary-support branch from 1f3808b to 58e1965 Compare December 19, 2019 16:36
@bkietz
Copy link
Member Author

bkietz commented Dec 19, 2019

@ursabot benchmark --suite-filter=compute-compare

@apache apache deleted a comment from ursabot Dec 19, 2019
@ursabot
Copy link

ursabot commented Dec 19, 2019

AMD64 Ubuntu 18.04 C++ Benchmark (#83895) builder has been succeeded.

Revision: 58e1965

  =================================  ===========  ===========  ==========
  benchmark                             baseline    contender      change
  =================================  ===========  ===========  ==========
- CompareArrayScalarKernel/32768/10  1.08485e+10  9.45131e+09  -0.128789
  CompareArrayScalarKernel/32768/1   1.09245e+10  1.07569e+10  -0.0153384
  CompareArrayScalarKernel/32768/50  7.03557e+09  1.05219e+10   0.495535
  CompareArrayArrayKernel/32768/1    4.96201e+09  6.18569e+09   0.24661
  CompareArrayArrayKernel/32768/50   6.31525e+09  6.16483e+09  -0.023819
  CompareArrayArrayKernel/32768/10   6.28338e+09  6.15006e+09  -0.0212182
  CompareArrayScalarKernel/32768/0   1.0598e+10   1.07744e+10   0.0166504
  CompareArrayArrayKernel/32768/0    5.09128e+09  6.40893e+09   0.258805
  =================================  ===========  ===========  ==========

@bkietz bkietz deleted the 6902-Add-String-Binary-support branch February 25, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants