PARQUET-1772: [C++] ParquetFileWriter: Data overwritten in append mode #6228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect when the output stream provided is in append mode and raise an exception. This is done to prevent existing data being overwritten as Parquet does not yet support appending data to existing files.
|
This broke a number of things, I just pushed fixes |
unit test in arrow-dataset-file-parquet-test
Thank you! I have fixed the remaining failed test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect when the output stream provided is in append mode and raise an
exception. This is done to prevent existing data being overwritten as
Parquet does not yet support appending data to existing files.