ARROW-6841: [C++] Migrate to LLVM 8 #6266

naitoh · 2020-01-23T15:06:11Z

We also use clang-format-8 and clang-tidy-8 too.

We use LLVM 8 for all places but we still support LLVM 7 for now.
Because some Ursabot based CI still uses LLVM 7.

github-actions · 2020-01-23T15:45:30Z

https://issues.apache.org/jira/browse/ARROW-6841

wesm · 2020-01-23T18:34:04Z

Thank you for looking at this. I'm guessing there are some clang-format changes

cc @pravindra @praveenbingo @projjal -- definitely want to get a thumbs up on upgrading LLVM 7 -> 8 from the Gandiva side

This change should probably go in after 0.16.0 is cut to minimize unknown issues?

pprudhvi · 2020-02-03T11:37:35Z

@ursabot crossbow submit -g gandiva

kszucs · 2020-02-03T11:38:01Z

AMD64 Conda Crossbow Submit (#88992) builder has been succeeded.

Revision: 8c3b03f

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-485

Task	Status
gandiva-jar-osx
gandiva-jar-trusty

pprudhvi · 2020-02-05T06:28:22Z

@ursabot crossbow submit -g gandiva

kszucs · 2020-02-05T06:28:50Z

AMD64 Conda Crossbow Submit (#89297) builder has been succeeded.

Revision: 8c3b03f

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-487

Task	Status
gandiva-jar-osx
gandiva-jar-trusty

pprudhvi · 2020-02-05T06:56:42Z

we can merge this once the gandiva jobs succeed.
The gandiva-jar-osx build will pass if we rebase on latest master. For gandiva-jar-trusty job, we need to upgrade the docker image. So far these are the changes made for the docker image: pprudhvi@701f286 , the build is still failing-https://quay.io/repository/prudhvi/gandivacentos/build/1f11df72-159a-4ec4-8546-9b53c5936b70 . Will update when I have all the changes required for the linux job to pass.

kou · 2020-02-10T09:06:24Z

I'll take over the task to split LLVM version for tools and Gandiva.
(It'll be a CMake improvement.)

naitoh · 2020-02-13T15:02:38Z

I rebased this branch to avoid conflicts.

I'll take over the task to split LLVM version for tools and Gandiva.
(It'll be a CMake improvement.)

Thank you for your support.

wesm · 2020-02-24T17:10:47Z

Anything anyone can do to help with this?

- linux-apt-jni.dockerfile update. - ci/docker/debian-10-cpp.dockerfile update - Commented out of ARROW_LLVM_VERSION_FALLBACK.

- Updated Fedora from 29 to 30 to use LLVM8.

kou · 2020-03-16T21:43:15Z

@naitoh Could you create an account on JIRA to assign you this issue?
https://issues.apache.org/jira/browse/ARROW-6841

wesm · 2020-03-16T22:12:19Z

We'll have to run clang-format-8 on the C++ code

wesm · 2020-03-16T23:36:21Z

The changes look okay to me. I agree with upgrading to LLVM 9 soon if it's been upgraded to stable

kou · 2020-03-16T23:41:41Z

OK. I'll apply these changes.

nealrichardson · 2020-03-17T00:20:17Z

https://github.com/apache/arrow/blob/master/r/README.md#editing-rcpp-code still says "clang-format-7" in a couple of places; could you please update those instructions? Thanks for doing this.

kou · 2020-03-17T00:20:48Z

OK!

kou · 2020-03-17T00:36:09Z

@github-actions crossbow submit -g nightly

github-actions · 2020-03-17T00:37:34Z

Revision: 3423cb7

Submitted crossbow builds: ursa-labs/crossbow @ actions-11

Task	Status
centos-6
centos-7
centos-8
conda-linux-gcc-py36
conda-linux-gcc-py37
conda-linux-gcc-py38
conda-osx-clang-py36
conda-osx-clang-py37
conda-osx-clang-py38
conda-win-vs2015-py36
conda-win-vs2015-py37
conda-win-vs2015-py38
debian-buster
debian-stretch
gandiva-jar-osx
gandiva-jar-trusty
homebrew-cpp
macos-r-autobrew
test-conda-cpp
test-conda-cpp-valgrind
test-conda-python-3.6
test-conda-python-3.7
test-conda-python-3.7-dask-latest
test-conda-python-3.7-hdfs-2.9.2
test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
test-conda-python-3.7-pandas-latest
test-conda-python-3.7-pandas-master
test-conda-python-3.7-spark-master
test-conda-python-3.7-turbodbc-latest
test-conda-python-3.7-turbodbc-master
test-conda-python-3.8-dask-master
test-conda-python-3.8-jpype
test-conda-python-3.8-pandas-latest
test-conda-r-3.6
test-debian-10-cpp
test-debian-10-go-1.12
test-debian-10-python-3
test-debian-c-glib
test-debian-ruby
test-fedora-30-cpp
test-fedora-30-python-3
test-r-rhub-debian-gcc-devel
test-r-rhub-ubuntu-gcc-release
test-r-rocker-r-base-latest
test-r-rstudio-r-base-3.6-bionic
test-r-rstudio-r-base-3.6-centos6
test-r-rstudio-r-base-3.6-opensuse15
test-r-rstudio-r-base-3.6-opensuse42
test-ubuntu-16.04-cpp
test-ubuntu-18.04-cpp
test-ubuntu-18.04-cpp-cmake32
test-ubuntu-18.04-cpp-release
test-ubuntu-18.04-cpp-static
test-ubuntu-18.04-docs
test-ubuntu-18.04-python-3
test-ubuntu-18.04-r-sanitizer
test-ubuntu-c-glib
test-ubuntu-ruby
ubuntu-bionic
ubuntu-eoan
ubuntu-xenial
wheel-manylinux1-cp35m
wheel-manylinux1-cp36m
wheel-manylinux1-cp37m
wheel-manylinux1-cp38
wheel-manylinux2010-cp35m
wheel-manylinux2010-cp36m
wheel-manylinux2010-cp37m
wheel-manylinux2010-cp38
wheel-manylinux2014-cp35m
wheel-manylinux2014-cp36m
wheel-manylinux2014-cp37m
wheel-manylinux2014-cp38
wheel-osx-cp35m
wheel-osx-cp36m
wheel-osx-cp37m
wheel-osx-cp38
wheel-win-cp36m
wheel-win-cp37m
wheel-win-cp38

kou · 2020-03-17T02:52:48Z

@github-actions crossbow submit ubuntu-xenial

github-actions · 2020-03-17T02:57:02Z

Revision: e5fc337

Submitted crossbow builds: ursa-labs/crossbow @ actions-12

Task	Status
ubuntu-xenial

naitoh · 2020-03-17T03:35:30Z

@naitoh Could you create an account on JIRA to assign you this issue?
https://issues.apache.org/jira/browse/ARROW-6841

@kou Thank you for your support!
I have created my JIRA account "naitoh".

kou · 2020-03-17T03:56:31Z

Thanks! I've assigned you to this issue.

kou · 2020-03-17T04:03:18Z

@github-actions crossbow submit ubuntu-xenial

github-actions · 2020-03-17T04:05:00Z

Revision: 24adc52

Submitted crossbow builds: ursa-labs/crossbow @ actions-13

Task	Status
ubuntu-xenial

wesm · 2020-03-17T21:35:57Z

Looks like we can merge this, any objections?

naitoh · 2020-03-17T23:17:29Z

Looks like we can merge this, any objections?

No objection from me.
Thanks to @kou and @pprudhvi for their support for this PR.

kou · 2020-03-17T23:37:25Z

@kszucs I keep LLVM 7 support because Ursabot jobs still use LLVM 7:
https://github.com/apache/arrow/pull/6266/files#diff-6725b893dfc969abac4f4ee39a3a317fR95

We can drop LLVM 7 support after we merge this pull request and upgrade LLVM version for Ursabot jobs.

wesm · 2020-03-18T01:16:06Z

OK, thank you. cc @kszucs

Merging this and will notify the mailing list about upgrading toolchains

pprudhvi mentioned this pull request Feb 10, 2020

ARROW-7812: [Packaging][Python] manylinux1 docker image changes for LLVM 8 #6394

Closed

naitoh force-pushed the ARROW-6841 branch from 8c3b03f to bbffc92 Compare February 13, 2020 12:13

h-vetinari mentioned this pull request Feb 28, 2020

Updating LLVM conda-forge/arrow-cpp-feedstock#116

Closed

kou force-pushed the ARROW-6841 branch from bbffc92 to 4c2c402 Compare March 14, 2020 22:43

naitoh and others added 11 commits March 17, 2020 06:29

ARROW-6841: [C++] Migrate to LLVM 8.

7d7d468

- linux-apt-jni.dockerfile update. - ci/docker/debian-10-cpp.dockerfile update - Commented out of ARROW_LLVM_VERSION_FALLBACK.

ARROW-6841: [C++] Migrate to LLVM 8.

3614f16

- Updated Fedora from 29 to 30 to use LLVM8.

Split Gandiva's LLVM version and Clang tools version

3055dca

Add missing apt-tranpsport-https

b17bcaf

Use Clang 7 for lint

aeb167b

Use LLVM_VERSION in .env by Linux packages

a1be5f6

Add missing buster-backports

6be0a01

Remove needless fedora_version

f5a8df6

Simplify

9645b24

Remove _version

8f8aad8

Install LLVM for IWYU

1563e01

kou force-pushed the ARROW-6841 branch from bfb68bd to 1563e01 Compare March 16, 2020 21:42

kou added 2 commits March 17, 2020 08:20

Remove _VERSION

39b8a96

Remove needless build argument

b64870b

Use clang-format-8

7486800

pprudhvi and others added 6 commits March 17, 2020 09:22

docker image changes

7dbbe86

update comment

61873a3

don't install wget

bcfa26c

set base docker to 2020-01-31-d8fa357

4ad0660

Use tag instead of sha256

c69f69d

Use clang-format-8

3423cb7

kou force-pushed the ARROW-6841 branch from 87fb18e to 3423cb7 Compare March 17, 2020 00:25

kou changed the title ~~ARROW-6841: [C++] Migrate to LLVM 8 and Updated Fedora 30~~ ARROW-6841: [C++] Migrate to LLVM 8 Mar 17, 2020

kou added 2 commits March 17, 2020 11:26

Fix quote

3ba2bc5

Install wget explicitly

e5fc337

Fix clang detection

24adc52

wesm closed this in 58ec1bc Mar 18, 2020

asfimport mentioned this pull request Mar 18, 2020

[C++] Upgrade to LLVM 8 #23171

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-6841: [C++] Migrate to LLVM 8 #6266

ARROW-6841: [C++] Migrate to LLVM 8 #6266

naitoh commented Jan 23, 2020 •

edited by kou

github-actions bot commented Jan 23, 2020

wesm commented Jan 23, 2020

pprudhvi commented Feb 3, 2020

kszucs commented Feb 3, 2020

pprudhvi commented Feb 5, 2020

kszucs commented Feb 5, 2020

pprudhvi commented Feb 5, 2020 •

edited

kou commented Feb 10, 2020

naitoh commented Feb 13, 2020

wesm commented Feb 24, 2020

kou commented Mar 16, 2020

wesm commented Mar 16, 2020

wesm commented Mar 16, 2020 •

edited

kou commented Mar 16, 2020

nealrichardson commented Mar 17, 2020

kou commented Mar 17, 2020

kou commented Mar 17, 2020

github-actions bot commented Mar 17, 2020

kou commented Mar 17, 2020

github-actions bot commented Mar 17, 2020

naitoh commented Mar 17, 2020

kou commented Mar 17, 2020

kou commented Mar 17, 2020

github-actions bot commented Mar 17, 2020

wesm commented Mar 17, 2020

naitoh commented Mar 17, 2020

kou commented Mar 17, 2020

wesm commented Mar 18, 2020

ARROW-6841: [C++] Migrate to LLVM 8 #6266

ARROW-6841: [C++] Migrate to LLVM 8 #6266

Conversation

naitoh commented Jan 23, 2020 • edited by kou

github-actions bot commented Jan 23, 2020

wesm commented Jan 23, 2020

pprudhvi commented Feb 3, 2020

kszucs commented Feb 3, 2020

pprudhvi commented Feb 5, 2020

kszucs commented Feb 5, 2020

pprudhvi commented Feb 5, 2020 • edited

kou commented Feb 10, 2020

naitoh commented Feb 13, 2020

wesm commented Feb 24, 2020

kou commented Mar 16, 2020

wesm commented Mar 16, 2020

wesm commented Mar 16, 2020 • edited

kou commented Mar 16, 2020

nealrichardson commented Mar 17, 2020

kou commented Mar 17, 2020

kou commented Mar 17, 2020

github-actions bot commented Mar 17, 2020

kou commented Mar 17, 2020

github-actions bot commented Mar 17, 2020

naitoh commented Mar 17, 2020

kou commented Mar 17, 2020

kou commented Mar 17, 2020

github-actions bot commented Mar 17, 2020

wesm commented Mar 17, 2020

naitoh commented Mar 17, 2020

kou commented Mar 17, 2020

wesm commented Mar 18, 2020

naitoh commented Jan 23, 2020 •

edited by kou

pprudhvi commented Feb 5, 2020 •

edited

wesm commented Mar 16, 2020 •

edited