ARROW-7665: [R] Build in parallel in linuxLibs.R #6271
Conversation
Also fix the dependency relationship between Bison and Flex
r/tools/linuxlibs.R
Outdated
| @@ -233,7 +240,7 @@ ensure_cmake <- function() { | |||
| } | |||
|
|
|||
| # TODO: move ensure_flex/bison/m4 to cmake: https://issues.apache.org/jira/browse/ARROW-7501 | |||
| ensure_flex <- function(m4 = ensure_m4()) { | |||
| ensure_flex <- function(m4 = ensure_m4(), bison = ensure_bison()) { | |||
There was a problem hiding this comment.
Why this change? bison seems to be an optional dependency of flex, and thrift seems to build and work just fine as it is. Did you have a build problem that this fixed?
There was a problem hiding this comment.
Well, yes, Flex fails building otherwise.
There was a problem hiding this comment.
I of course would be happy to have this bison/flex code moved out of this R script and into cmake proper (https://issues.apache.org/jira/browse/ARROW-7501).
There was a problem hiding this comment.
I'm only interested in fixing this and speeding it up :)
There was a problem hiding this comment.
How did you get Flex to fail to build otherwise? Maybe we should add that container to our build matrix. It's not failing for crossbow or GHA, and I never had it fail locally for me with those docker images (though I did see the message that flex was building without bison and chose not to care since thrift successfully built).
There was a problem hiding this comment.
I ran the container locally, roughly like this:
$ export R_TAG=3.6-centos7
$ export R_IMAGE=r-base
$ export R_ORG=rstudio
$ docker-compose build r
$ docker-compose run --rm r
It's the same container as on Travis-CI, AFAICT.
There was a problem hiding this comment.
Yeah that's what's running on all commits and it's passing on master. It makes some noise about flex not having bison but it says not to worry: https://github.com/apache/arrow/runs/405798341#step:5:809
checking for bison... no
configure: no bison program found: only required for maintainers
I'm fine with the change if everything passes, but I suspect it's not necessary.
There was a problem hiding this comment.
Ah, I see... I saw the same error as here and thought that was the cause for the failing builds:
https://github.com/apache/arrow/runs/405798341#step:5:1028
I could try to remove those changes.
|
@ursabot crossbow submit -g r |
|
AMD64 Conda Crossbow Submit (#88084) builder has been succeeded. Revision: 7de0f15 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-452
|
Also fix the dependency relationship between Bison and Flex