Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-7633: [C++][CI] Create fuzz targets for tensors and sparse tensors #6302

Closed
wants to merge 14 commits into from
Closed

ARROW-7633: [C++][CI] Create fuzz targets for tensors and sparse tensors #6302

wants to merge 14 commits into from

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Jan 28, 2020

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-7633

@mrkn mrkn force-pushed the ARROW-7633 branch 3 times, most recently from e5e99a5 to 1c44410 Compare February 4, 2020 06:19
@mrkn mrkn force-pushed the ARROW-7633 branch 3 times, most recently from 637f086 to 19ef6f5 Compare February 13, 2020 01:35
@emkornfield
Copy link
Contributor

@mrkn it looks like this needs a rebase? Were you going to pursue these changes (PR is still marked as a draft?)

@mrkn
Copy link
Member Author

mrkn commented Sep 14, 2020

@emkornfield The reason why this is marked as draft is that I intend to include the fuzz target for sparse tensors. But I need more time to do it, so I want to split a pull request for sparse tensors.

I'll fix this and rebase to the mater branch asap.

@mrkn
Copy link
Member Author

mrkn commented Sep 28, 2020

I need more several days for syncing this pull-request to the latest master branch.

@mrkn mrkn force-pushed the ARROW-7633 branch 6 times, most recently from 5ee93da to b6bec6f Compare October 5, 2020 22:43
@mrkn mrkn marked this pull request as ready for review October 5, 2020 22:44
@mrkn
Copy link
Member Author

mrkn commented Oct 6, 2020

This pull request is ready to review.

@pitrou Could you have a look?

@mrkn mrkn requested a review from pitrou October 6, 2020 14:47
@pitrou
Copy link
Member

pitrou commented Oct 6, 2020

I'll take a look later this week.

@mrkn
Copy link
Member Author

mrkn commented Oct 7, 2020

Rebased due to #8350.

@mrkn
Copy link
Member Author

mrkn commented Oct 7, 2020

Need to rebase again after #8373 is merged.

@mrkn mrkn force-pushed the ARROW-7633 branch 2 times, most recently from 850954c to 1adb812 Compare October 7, 2020 08:20
@wesm
Copy link
Member

wesm commented Dec 7, 2020

@mrkn @pitrou any chance this is close to being mergeable?

mrkn
mrkn commented Jan 18, 2021
View reviewed changes
cpp/src/arrow/ipc/metadata_internal.cc Outdated
@@ -1349,17 +1349,23 @@ Status GetTensorMetadata(const Buffer& metadata, std::shared_ptr<DataType>* type
return Status::IOError("Header-type of flatbuffer-encoded Message is not Tensor.");
}

int ndim = static_cast<int>(tensor->shape()->size());
const auto ndim = tensor->shape()->size();
using ndim_type = std::remove_const<decltype(ndim)>::type;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple decltype(ndim) is modified by const so we need to use std::remove_const here.

@mrkn
Copy link
Member Author

mrkn commented Jan 19, 2021

@pitrou I changed for your comments and left one reply comment.
One CI job on travis-ci failed but it seems unrelated to this pull-request.

@pitrou
Copy link
Member

pitrou commented Jan 19, 2021

Indeed, the CI failure is probably unrelated. I restarted it.

@pitrou
Copy link
Member

pitrou commented Jan 19, 2021

I rebased.

@pitrou
Copy link
Member

pitrou commented Jan 19, 2021

CI passed on my fork, will merge. Thank you @mrkn !

@pitrou pitrou closed this in 275fda1 Jan 19, 2021
@mrkn mrkn deleted the ARROW-7633 branch January 21, 2021 01:36
kszucs pushed a commit that referenced this pull request Jan 25, 2021
@mrkn @pitrou @kszucs
ARROW-7633: [C++][CI] Create fuzz targets for tensors and sparse tensors
d6be461 
Closes #6302 from mrkn/ARROW-7633

Lead-authored-by: Kenta Murata <mrkn@mrkn.jp>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@mrkn @pitrou @GeorgeAp
ARROW-7633: [C++][CI] Create fuzz targets for tensors and sparse tensors
69b3dd4 
Closes apache#6302 from mrkn/ARROW-7633

Lead-authored-by: Kenta Murata <mrkn@mrkn.jp>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
@mrkn @pitrou @michalursa
ARROW-7633: [C++][CI] Create fuzz targets for tensors and sparse tensors
53956f4 
Closes apache#6302 from mrkn/ARROW-7633

Lead-authored-by: Kenta Murata <mrkn@mrkn.jp>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Apr 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrkn @emkornfield @pitrou @wesm