ARROW-7742: [GLib] Add support for MapArray #6436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested changes
Feb 19, 2020
c_glib/arrow-glib/array-builder.cpp
Outdated
| { | ||
| GObjectClass *gobject_class; | ||
|
|
||
| gobject_class = G_OBJECT_CLASS(klass); |
There was a problem hiding this comment.
Could you use auto gobject_class = ... here?
c_glib/arrow-glib/array-builder.cpp
Outdated
| * @data_type: #GArrowMapDataType for the map. | ||
| * @error: (nullable): Return location for a #GError or %NULL. | ||
| * | ||
| * Returns: A newly created #GArrowMapArrayBuilder. |
There was a problem hiding this comment.
Could you add on success, %NULL on error?
c_glib/arrow-glib/array-builder.cpp
Outdated
| auto builder = garrow_array_builder_new(arrow_data_type, | ||
| error, | ||
| "[map-array-builder][new]"); | ||
| return GARROW_MAP_ARRAY_BUILDER(builder); |
c_glib/arrow-glib/array-builder.cpp
Outdated
| garrow_array_builder_get_raw(GARROW_ARRAY_BUILDER(builder))); | ||
|
|
||
| auto status = arrow_builder->Append(); | ||
| return garrow_error_check(error, |
| arrow_items, | ||
| arrow_memory_pool, | ||
| &arrow_array); | ||
| if (garrow_error_check(error, status, "[map-array][new]")) { |
| auto data_type = GARROW_DATA_TYPE(map_data_type); | ||
| auto arrow_data_type = garrow_data_type_get_raw(data_type); | ||
| auto arrow_map_data_type = | ||
| static_cast<arrow::MapType *>(arrow_data_type.get()); |
There was a problem hiding this comment.
Can we use std::static_pointer_cast<arrow::MapType>(arrow_data_type) here?
| auto data_type = GARROW_DATA_TYPE(map_data_type); | ||
| auto arrow_data_type = garrow_data_type_get_raw(data_type); | ||
| auto arrow_map_data_type = | ||
| static_cast<arrow::MapType *>(arrow_data_type.get()); |
|
|
||
| def setup | ||
| offsets = build_int32_array([0, 2, 5]) | ||
| @keys = build_string_array(["a", "b", "c", "d", "e"]) |
| def setup | ||
| offsets = build_int32_array([0, 2, 5]) | ||
| @keys = build_string_array(["a", "b", "c", "d", "e"]) | ||
| @items = build_int16_array([0, 1, 2, 3, 4]) |
c_glib/arrow-glib/array-builder.cpp
Outdated
| * @builder: A #GArrowMapArrayBuilder. | ||
| * | ||
| * Returns: (transfer none): The #GArrowArrayBuilder for struct values. | ||
| * This is used instead of garrow_map_array_builder_get_key_builder() and garrow_map_array_builder_get_item_builder(). |
There was a problem hiding this comment.
How about this?
* Returns: (transfer none): The #GArrowArrayBuilder to add map entries as struct values.
* This can be used instead of garrow_map_array_builder_get_key_builder() and
* garrow_map_array_builder_get_item_builder(). You can build map entries as a list of
* struct values with this builder.There was a problem hiding this comment.
Thank you for improving document. I've applied this.
shiro615
force-pushed
the
glib-map-array
branch
from
da5085a
to
4d84134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for
GArrowMapArrayBuilder,GArrowMapArray, andGArrowMapDataType.