ARROW-7929: [C++] Align CMake target names to upstreams #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the declared imported targets for glog, gtest and thrift to match the exported names produced by each projects generated _Name_Targets.cmake file. This makes it possible to use `CMAKE_FIND_PACKAGE_PREFER_CONFIG=ON` in conjunction with `ARROW_DEPENDENCY_SOURCE=SYSTEM`.
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
fsaintjacques
changed the title
bkietz
requested changes
Feb 24, 2020
|
@kszucs Some Ursabot builds are failed. Could you confirm whether this is Ursabot related problem or this PR related problem? BTW, I want to rebuild failed Ursabot builds manually. What do I need to do for it? |
10 tasks
bkietz
approved these changes
Feb 25, 2020
|
@kou login on the buildbot site and restart manually with the rebuild button, or... |
|
@ursabot build |
|
@kszucs Thanks! I didn't know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.