Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-7917: [C++] Find Python 3 in CMake configuration #6498

Closed
wants to merge 4 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Feb 27, 2020

Use the new FindPython3 package if available.

@pitrou
Copy link
Member Author

pitrou commented Feb 27, 2020

@kou @fsaintjacques

@github-actions
Copy link

@pitrou pitrou force-pushed the ARROW-7917-find-python3 branch 2 times, most recently from 6e3259e to 8a7b82f Compare February 27, 2020 16:32
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@pitrou pitrou force-pushed the ARROW-7917-find-python3 branch 5 times, most recently from 7316e7f to 772b542 Compare February 27, 2020 18:22
cpp/src/arrow/python/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/cmake_modules/FindPython3Alt.cmake Show resolved Hide resolved
cpp/cmake_modules/FindPython3Alt.cmake Show resolved Hide resolved
cpp/cmake_modules/FindPython3Alt.cmake Show resolved Hide resolved
@pitrou
Copy link
Member Author

pitrou commented Mar 2, 2020

@kou I updated the PR, do you want to take another look?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in c707d8b Mar 3, 2020
@pitrou pitrou deleted the ARROW-7917-find-python3 branch March 3, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants