Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-7991: [C++][Plasma] Allow option for evicting if full when creating an object #6520

Closed
wants to merge 10 commits into from

Conversation

stephanie-wang
Copy link
Contributor

Allow the client to pass in a flag during object creation specifying whether objects should be evicted or not.

@github-actions
Copy link

github-actions bot commented Mar 2, 2020

@pitrou
Copy link
Member

pitrou commented Mar 4, 2020

cc @pcmoritz @robertnishihara

@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 5, 2020

Thanks for the PR, the logic looks good to me! Let's make sure we do not break backwards compatibility of the PlasmaClient API though and move the evict_if_full argument to the end and have a default value of true (same for CreateAndSeal and CreateAndSealBatch). For consistency we should do the same for PlasmaClient::Impl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants