Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-8118: [R] dim method for FileSystemDataset #6635

Closed
wants to merge 23 commits into from
Closed

ARROW-8118: [R] dim method for FileSystemDataset #6635

wants to merge 23 commits into from

Commits on Mar 19, 2020

  1. add dim method to for Dataset objects

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    55b0fde View commit details
    Browse the repository at this point in the history

  2. add dim method for arrow_dplyr_query that only fails + test

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    3d17d34 View commit details
    Browse the repository at this point in the history

  3. rename dim error test

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d3c90b5 View commit details
    Browse the repository at this point in the history

  4. test directly on number of row and column integers

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    5e45e0f View commit details
    Browse the repository at this point in the history

  5. Update r/R/dataset.R 

    Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
    @boshek @nealrichardson
    boshek and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    8f8065d View commit details
    Browse the repository at this point in the history

  6. check that dim method has FileSystemDataset class and is a parquet file

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    275a5eb View commit details
    Browse the repository at this point in the history

  7. Update r/R/dataset.R 

    Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
    @boshek @nealrichardson
    boshek and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    af153fc View commit details
    Browse the repository at this point in the history

  8. remove the arrow_dplyr_query test since it will change

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    fe11e33 View commit details
    Browse the repository at this point in the history

  9. adding FileReader num_rows cpp code. 

    Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
    @boshek @bkietz @nealrichardson
    2 people authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d5a033f View commit details
    Browse the repository at this point in the history

  10. fix numbers to integers

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    5a06f6b View commit details
    Browse the repository at this point in the history

  11. return integer from dim and test accordingly

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    8060c40 View commit details
    Browse the repository at this point in the history

  12. expose FileReader num_rows as active binding and use in dim

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    ab3ae0f View commit details
    Browse the repository at this point in the history

  13. add more flexible dim.arrow_dplyr_query method + tests

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    741d5de View commit details
    Browse the repository at this point in the history

  14. remove redundant check

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    0d8ba77 View commit details
    Browse the repository at this point in the history

  15. Update r/R/dataset.R 

    Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
    @boshek @nealrichardson
    boshek and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    126c48b View commit details
    Browse the repository at this point in the history

  16. Update r/tests/testthat/test-dplyr.R 

    Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
    @boshek @nealrichardson
    boshek and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a38a32a View commit details
    Browse the repository at this point in the history

  17. Update r/R/dataset.R 

    Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
    @boshek @nealrichardson
    boshek and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    db2f9c3 View commit details
    Browse the repository at this point in the history

  18. add dim method to namespace

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    8e0516b View commit details
    Browse the repository at this point in the history

  19. better description of test

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    287a0eb View commit details
    Browse the repository at this point in the history

  20. better warning message

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d82da96 View commit details
    Browse the repository at this point in the history

  21. Update r/R/dataset.R 

    Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
    @boshek @nealrichardson
    boshek and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    0524469 View commit details
    Browse the repository at this point in the history

  22. coerce num_rows to an integer in active binding

    @boshek @nealrichardson
    boshek authored and nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    94885a8 View commit details
    Browse the repository at this point in the history

  23. Slight reorg and 💅

    @nealrichardson
    nealrichardson committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a2116d7 View commit details
    Browse the repository at this point in the history