ARROW-8158: [Java] Getting length of data buffer and base variable width vector #6684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyafan82
reviewed
Mar 23, 2020
java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java
Outdated
Show resolved
Hide resolved
emkornfield
reviewed
Mar 25, 2020
| /** | ||
| * Gets the ending offset of a record, given its index. | ||
| */ | ||
| protected final int getEndOffset(int index) { |
There was a problem hiding this comment.
why protected? I think the intent is to make this public?
There was a problem hiding this comment.
sorry, because the getStartOffset is protected and I didn't notice that. Now I have made getStartOffset/getEndOffset public.
|
+1 thanks. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For string data buffer and base variable width vector can we have a way to get length of the data?
For instance, in ArrowColumnVector in StringAccessor we use stringResult.start and stringResult.end, instead we would like to get length of the data through an exposed function.
Now we have getStartOffset in BaseVariableVector and getElementStartIndex/getElementEndIndex in BaseListVector. To be consistent, we add getEndOffset for BaseVariableVector.