ARROW-8226: [Go] Implement 64 bit offsets binary builder #6725
Conversation
Co-authored-by: Richard Artoul <richard.artoul@datadoghq.com>
The checkptr check in go 1.14 flags `unsafe.Pointer(uintptr(x))` as potentially unsafe due to the possibility of dereferencing arbitrary memory. This commit instead uses bare pointers for the length & byte fields
Avoid unsafe unsafe.Pointer usage
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
richardartoul
changed the title
|
@sbinet this is the new one |
|
@wesm Mind taking a look at this? |
|
ping @sbinet do you think you will have time to take a look? |
|
Can we merge this? |
|
Hm, at a high level it seems like it might be better to have a separate set of LargeBinary types rather than try to pack both 32-bit and 64-bit into the same types. This means some code duplication (given Go's current generics/templates situation) but perhaps for the best |
|
@sbinet could you assist with this? |
|
Just wanted to share that I probably can't contribute any more time to getting this merged, we've moved away from Arrow for our project (we still use the format in some cases, but its our own implementation of builders) at this. Nothing to do with the project itself, we just needed more control over allocations and serialization and it was easier for us if implemented it all ourselves |
|
Well, that is definitely a bummer. I hope to see some growth in the Go developer community here in the future. I'll close this PR for now then |
No description provided.