ARROW-8323: [C++] Add pragmas wrapping proto_utils.h to disable conversion warnings #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkietz could you please add a comment to remove the pin once your fix is released by grpc? |
|
Can we use |
|
@wesm I'll try it, but note that warning is globally disabled via a flag, SetupCxxFlags.cmake:152 (to no effect when combined with |
bkietz
force-pushed
the
8323-Pin-gRPC-at-v1-27-to-avoi
branch
from
28fcd4c
to
3fcea6f
Compare
bkietz
changed the title
|
Opened https://jira.apache.org/jira/browse/ARROW-8328 to investigate why the global conversion warning disable is not respected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.