ARROW-7233: [C++] Use Result<T> in remaining value-returning IPC APIs

[wesm]

There were a number of APIs left.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-7233

[wesm]

Please don't merge since this conflicts with #6804

[pitrou]

Looks like there are problems:

* checking whether package ‘arrow’ can be installed ... WARNING
Found the following significant warnings:
  /arrow/cpp/src/arrow/ipc/message.cc:123:1: warning: control reaches end of non-void function [-Wreturn-type]

/arrow/cpp/src/jni/orc/jni_wrapper.cpp: In function ‘_jbyteArray* Java_org_apache_arrow_adapter_orc_OrcStripeReaderJniWrapper_getSchema(JNIEnv*, jclass, jlong)’:
/arrow/cpp/src/jni/orc/jni_wrapper.cpp:231:87: error: ‘arrow::Status arrow::ipc::SerializeSchema(const arrow::Schema&, arrow::ipc::DictionaryMemo*, arrow::MemoryPool*, std::shared_ptr<arrow::Buffer>*)’ is deprecated: Deprecated in 0.17.0. Use Result-returning version [-Werror=deprecated-declarations]
       arrow::ipc::SerializeSchema(*schema, nullptr, arrow::default_memory_pool(), &out);
                                                                                       ^
In file included from /arrow/cpp/src/arrow/ipc/api.h:25:0,
                 from /arrow/cpp/src/jni/orc/jni_wrapper.cpp:26:
/arrow/cpp/src/arrow/ipc/writer.h:437:8: note: declared here
 Status SerializeSchema(const Schema& schema, DictionaryMemo* dictionary_memo,
        ^~~~~~~~~~~~~~~

[wesm]

Will fix. I used clang to build the R bindings so I missed some deprecation warnings (wonder if there's a way to get ARROW_DEPRECATED to warn in clang?)

This will need to get rebased after ARROW-8311

[pitrou]

Rebasing.

[pitrou]

+1, will merge if CI green.

[bkietz]

GLib failure https://github.com/apache/arrow/pull/6867/checks?check_run_id=574066551#step:5:1025
is https://issues.apache.org/jira/browse/ARROW-8373

[pitrou]

AppVeyor build in progress:
https://ci.appveyor.com/project/pitrou/arrow/builds/32069395

[wesm]

Thanks. This is going to cause some mayhem with ARROW-8311 though