ARROW-8370: [C++] Migrate type/schema APIs to Result<T> #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some clean up in the Python wrap/unwrap functions.
pitrou
force-pushed
the
ARROW-8370-result-type-apis
branch
from
aa36675
to
3d6a6c6
Compare
bkietz
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
LGTM, thanks again
This is the second time I've seen a failure to find gobject-introspection, @kou?
https://github.com/apache/arrow/pull/6872/checks?check_run_id=571082161#step:5:1023
https://github.com/apache/arrow/pull/6869/checks?check_run_id=570456337#step:5:1023
| PyObject*); \ | ||
| ARROW_PYTHON_EXPORT PyObject* wrap_##FUNC_SUFFIX(const std::shared_ptr<TYPE_NAME>&); \ | ||
| ARROW_DEPRECATED("Use Result-returning version") \ | ||
| ARROW_PYTHON_EXPORT Status unwrap_##FUNC_SUFFIX(PyObject*, \ |
There was a problem hiding this comment.
Is it necessary to deprecate these instead of just removing them? Aren't they internal?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok. In this case, I've renamed the XXX_record_batch APIs to XXX_batch, for consistency with the Cython API. Is that a problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some clean up in the Python wrap/unwrap functions.