Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-8662: [CI] Consolidate appveyor scripts #7080

Closed
wants to merge 10 commits into from
Closed

ARROW-8662: [CI] Consolidate appveyor scripts #7080

wants to merge 10 commits into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented May 1, 2020

No description provided.

@github-actions
Copy link

github-actions bot commented May 1, 2020

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@kszucs
Copy link
Member Author

kszucs commented May 1, 2020

Checking that the cache properly works on my fork's master branch.

@kszucs kszucs changed the title [CI] Consolidate appveyor scripts [WIP] ARROW-8662: [CI] Consolidate appveyor scripts May 1, 2020
@kszucs
Copy link
Member Author

kszucs commented May 1, 2020

First run: https://ci.appveyor.com/project/kszucs/arrow/builds/32582056
Second run: https://ci.appveyor.com/project/kszucs/arrow/builds/32583776

@github-actions
Copy link

github-actions bot commented May 1, 2020

https://issues.apache.org/jira/browse/ARROW-8662

@kszucs kszucs requested a review from pitrou May 1, 2020 15:11
pitrou
pitrou reviewed May 6, 2020
View reviewed changes
ci/appveyor-cpp-build.bat
set PYARROW_WITH_GANDIVA=%ARROW_BUILD_GANDIVA%
set PYARROW_WITH_PARQUET=ON
set PYARROW_WITH_S3=%ARROW_S3%
set PYARROW_WITH_STATIC_BOOST=ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the Boost-related settings are still useful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm takling that #7126

@pitrou
Copy link
Member

pitrou commented May 6, 2020

I've started a new build to check if the cache is being used.

@pitrou
Copy link
Member

pitrou commented May 6, 2020

It looks like caching is broken. Normally, you get this message at the end of a build:
https://ci.appveyor.com/project/pitrou/arrow/build/job/trhpyfqd55phh8wt#L2140

Updating build cache...
Cache 'C:\Users\Appveyor\clcache1' - Updated
Cache entry not found: C:\msys64\home\appveyor\.ccache
Cache entry not found: C:\Users\Appveyor\.cargo\registry
Cache entry not found: C:\Users\appveyor\AppData\Local\\go-build
Build success

The message is absent on this PR:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/32681460/job/c8aq4o6dgjbpi34k#L1897

@pitrou
Copy link
Member

pitrou commented May 6, 2020

Ah, my bad, it seems caching is not enabled on PR builds but on personal builds:
https://ci.appveyor.com/project/kszucs/arrow/build/job/fj6dudpvm2pw2yvj#L1893

@pitrou
Copy link
Member

pitrou commented May 6, 2020

Opened for https://issues.apache.org/jira/browse/INFRA-20239 to ask for enabling the cache on PR builds.

@kszucs
Copy link
Member Author

kszucs commented May 8, 2020

@pitrou I guess we shouldn't block on the infra ticket.

@nealrichardson
Copy link
Contributor

Interpreting that 👍 as an approval. Appveyor passed so I'm merging.

@pitrou
Copy link
Member

pitrou commented May 20, 2020

ci/detect_changes.py was still used on Travis, so now Travis builds are a no-op.

@pitrou pitrou mentioned this pull request May 20, 2020
Closed
pitrou added a commit that referenced this pull request May 20, 2020
@pitrou
ARROW-8872: [CI] Restore ci/detect-changes.py
fd9bf16 
This is needed for Travis-CI builds to function properly.
The file was mistakingly removed in db1c49a, part of PR #7080 (fixing ARROW-8662).

Closes #7234 from pitrou/ARROW-8872-ci-detect-changes

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
pprudhvi pushed a commit to pprudhvi/arrow that referenced this pull request May 26, 2020
@pitrou @pprudhvi
ARROW-8872: [CI] Restore ci/detect-changes.py
b69790c 
This is needed for Travis-CI builds to function properly.
The file was mistakingly removed in db1c49a, part of PR apache#7080 (fixing ARROW-8662).

Closes apache#7234 from pitrou/ARROW-8872-ci-detect-changes

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kszucs @pitrou @nealrichardson