Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-8770: [C++][CI] Enable arrow-csv-test on s390x #7152

Closed
wants to merge 1 commit into from
Closed

ARROW-8770: [C++][CI] Enable arrow-csv-test on s390x #7152

wants to merge 1 commit into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented May 12, 2020

This PR enables arrow-csv-test on TravisCI on s390x. This testsuite can pass with the latest master.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-8770

@kiszk
Copy link
Member Author

kiszk commented May 12, 2020

Now, we can see arrow-csv-test pass at here.

      Start 25: arrow-csv-test
22/56 Test #22: arrow-io-memory-test .................   Passed    2.28 sec
      Start 26: arrow-compute-compute-test
23/56 Test #26: arrow-compute-compute-test ...........   Passed    0.09 sec
      Start 27: arrow-compute-boolean-test
24/56 Test #25: arrow-csv-test .......................   Passed    0.35 sec

pitrou
pitrou reviewed May 12, 2020
View reviewed changes
.travis.yml
@@ -88,7 +87,6 @@ script:
ulimit -c unlimited || :
- |
archery docker run \
-e ARROW_CSV=${ARROW_CSV:-ON} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Member Author

@kiszk kiszk May 12, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was suggested to remove a line at archery docker run in the previous PR when a new flag was enabled. cc @kou

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am neutral on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, fair enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it if we don't need to change the default -DARROW_CSV.
If we have multiple default definitions, they will confuse us.

@pitrou pitrou closed this in 68544b9 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiszk @kou @pitrou