ARROW-9023: [C++] Use mimalloc conda package #7342
Conversation
| @@ -1367,7 +1370,7 @@ endif() | |||
| # ---------------------------------------------------------------------- | |||
| # mimalloc - Cross-platform high-performance allocator, from Microsoft | |||
|
|
|||
| if(ARROW_MIMALLOC) | |||
| macro(build_mimalloc) | |||
| message(STATUS "Building (vendored) mimalloc from source") | |||
| # We only use a vendored mimalloc as we want to control its build options. | |||
There was a problem hiding this comment.
Is this comment obsolete? Does conda-forge uses the same build options as we do?
There was a problem hiding this comment.
😞 Thought so but missed MI_OVERRIDE, not sure whether we can set that on conda-forge
|
Will have a look at this in some weeks again, closing for now. |
|
We should try to ship mimalloc in Windows conda builds for 1.0.0, @kszucs do you think you might be able to help? |
Vendoring should be a viable solution if we include the LICENSE file. The conda package is not working on Windows and I fail debug it. |
|
Ah OK. Then using BUNDLED on conda-forge should be OK |
|
I'm a bit confused since mimalloc is already enabled in the arrow-cpp-feedstock although its license is not included in ours. I assume we should leave the conda forge packages as is and have a jira about including mimalloc's license in our license file? |
No description provided.