ARROW-9308: [Format] Add Feature enum for forward compatibility. #7502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
emkornfield
commented
Jun 25, 2020
format/Schema.fbs
Outdated
| /// Enums added to this list should be assigned power-of-two values | ||
| /// to facilitate exchanging and comparing bitmaps for supported | ||
| /// features. | ||
| enum Feature : int { |
There was a problem hiding this comment.
this should probably be "long" if possible
emkornfield
changed the title
|
+1 approved on ML by vote. |
sgnkc
pushed a commit
to sgnkc/arrow
that referenced
this pull request
Jul 6, 2020
Will start a discussion on the mailing list shortly. Closes apache#7502 from emkornfield/feature_flag Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will start a discussion on the mailing list shortly.