ARROW-9495: [C++] Equality assertions don't handle Inf / -Inf properly #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyafan82
force-pushed
the
fly_0724_eq
branch
2 times, most recently
from
c1943d5
to
d7766f3
Compare
kiszk
reviewed
Jul 25, 2020
cpp/src/arrow/array/array_test.cc
Outdated
| // Infinity in a valid entry | ||
| ArrayFromVector<TYPE>(type, {false, true}, {0.5, infinity}, &a); | ||
| ArrayFromVector<TYPE>(type, {false, true}, {0.5, infinity}, &b); | ||
| std::cout << a->ToString() << std::endl; |
There was a problem hiding this comment.
Removed. Thanks for your kind reminder.
|
Looks good to me |
pitrou
requested changes
Aug 13, 2020
| left, right, [epsilon](T x, T y) -> bool { return fabs(x - y) <= epsilon; }); | ||
| return BaseFloatingEquals<ArrowType>(left, right, [epsilon](T x, T y) -> bool { | ||
| return (fabs(x - y) <= epsilon) || (x == y); | ||
| }); |
There was a problem hiding this comment.
You must also change the nans_equal path above.
There was a problem hiding this comment.
Revised accordingly. Thanks a lot for your kind reminder.
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Sep 8, 2020
See https://issues.apache.org/jira/browse/ARROW-9495 Closes apache#7826 from liyafan82/fly_0724_eq Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
See https://issues.apache.org/jira/browse/ARROW-9495 Closes apache#7826 from liyafan82/fly_0724_eq Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
See https://issues.apache.org/jira/browse/ARROW-9495 Closes apache#7826 from liyafan82/fly_0724_eq Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/ARROW-9495