ARROW-9604: [C++] Add aggregate min/max benchmark #7870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankdjx
force-pushed
the
min_max_bm
branch
2 times, most recently
from
372f4bf
to
064650b
Compare
pitrou
reviewed
Aug 12, 2020
| MINMAX_KERNEL_BENCHMARK(MinMaxKernelInt32, Int32Type); | ||
| MINMAX_KERNEL_BENCHMARK(MinMaxKernelInt64, Int64Type); | ||
|
|
||
| static void CountKernelInt64(benchmark::State& state) { |
There was a problem hiding this comment.
I don't think it's important to benchmark the count kernel. It's a trivial O(1) kernel.
Also add count. Signed-off-by: Frank Du <frank.du@intel.com>
pitrou
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Thank you. Example output (AMD Ryzen, AVX2):
MinMaxKernelFloat/1048576/10000 222 us 222 us 3159 bytes_per_second=4.40764G/s null_percent=0.01 size=1048.58k
MinMaxKernelFloat/1048576/100 233 us 233 us 3002 bytes_per_second=4.19139G/s null_percent=1 size=1048.58k
MinMaxKernelFloat/1048576/10 399 us 399 us 1759 bytes_per_second=2.45046G/s null_percent=10 size=1048.58k
MinMaxKernelFloat/1048576/2 934 us 934 us 726 bytes_per_second=1071.02M/s null_percent=50 size=1048.58k
MinMaxKernelFloat/1048576/1 339 us 339 us 1973 bytes_per_second=2.87805G/s null_percent=100 size=1048.58k
MinMaxKernelFloat/1048576/0 187 us 187 us 3723 bytes_per_second=5.21389G/s null_percent=0 size=1048.58k
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Add benchmark for aggregate min/max compute kernels Signed-off-by: Frank Du <frank.du@intel.com> Closes apache#7870 from jianxind/min_max_bm Lead-authored-by: Frank Du <frank.du@intel.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmark for aggregate min/max compute kernels
Signed-off-by: Frank Du frank.du@intel.com