ARROW-9642: [C++] Let MakeBuilder refer DictionaryType's index_type for deciding the starting bit width of the indices #7898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Aug 10, 2020
mrkn
force-pushed
the
ARROW-9642
branch
5 times, most recently
from
64f06da
to
bb91c38
Compare
|
@mrkn I don't think it is, feel free to add it :-) |
|
@pitrou OK, I'll do it. |
pitrou
requested changes
Aug 12, 2020
mrkn
force-pushed
the
ARROW-9642
branch
3 times, most recently
from
cd94c43
to
b12606c
Compare
|
@pitrou I've finished. Could you please have a look at this again? |
pitrou
requested changes
Aug 31, 2020
cpp/src/arrow/array/builder_dict.h
Outdated
| @@ -93,6 +93,10 @@ class ARROW_EXPORT DictionaryMemoTable { | |||
| std::unique_ptr<DictionaryMemoTableImpl> impl_; | |||
| }; | |||
|
|
|||
| /// \brief Check array's value type by DCHECK | |||
| ARROW_EXPORT void CheckArrayType(const std::shared_ptr<DataType>& expected_type, | |||
| const Array& array, const std::string& message); | |||
There was a problem hiding this comment.
Can you make this a protected method of DictionaryBuilderBase or something? We don't want to expose it as a public API.
There was a problem hiding this comment.
Also, take const char* for the error message, to avoid constructing a std::string.
There was a problem hiding this comment.
I'll make this a protected method of ArrayBuilder.
|
@pitrou I've finished. Could you please have a look at this again? |
This check is available only on debug build.
Avoid crashing since we can return an error
pitrou
approved these changes
Sep 1, 2020
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
…or deciding the starting bit width of the indices As [the discussion in arrow-dev ML](https://lists.apache.org/thread.html/r69b17b5043bc629507440e962fd50d087c8833cd70682651c6ebda3d%40%3Cdev.arrow.apache.org%3E), it may be better that when creating a dictionary builder by MakeBuilder function, we can specify the starting bit width of the builder's index by the dictionary index type specified in the argument of MakeBuilder. Closes apache#7898 from mrkn/ARROW-9642 Lead-authored-by: Kenta Murata <mrkn@mrkn.jp> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…or deciding the starting bit width of the indices As [the discussion in arrow-dev ML](https://lists.apache.org/thread.html/r69b17b5043bc629507440e962fd50d087c8833cd70682651c6ebda3d%40%3Cdev.arrow.apache.org%3E), it may be better that when creating a dictionary builder by MakeBuilder function, we can specify the starting bit width of the builder's index by the dictionary index type specified in the argument of MakeBuilder. Closes apache#7898 from mrkn/ARROW-9642 Lead-authored-by: Kenta Murata <mrkn@mrkn.jp> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the discussion in arrow-dev ML, it may be better that when creating a dictionary builder by MakeBuilder function, we can specify the starting bit width of the builder's index by the dictionary index type specified in the argument of MakeBuilder.