Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-9736 : [Ruby] gem no doc tweak #7912

Closed

Conversation

Rajpratik71
Copy link
Contributor

Optimization tweak for ruby gems no doc while gems installation using
"--no-document" . Also removal of depricated "--no-ri" and "--no-rdoc".

More detail can be found at
https://guides.rubygems.org/command-reference/#installupdate-options-2

Signed-off-by: Pratik raj rajpratik71@gmail.com

Optimization tweak for ruby gems no doc while gems installation using
 "--no-document" . Also removal of depricated "--no-ri" and "--no-rdoc".

 More detail can be found at
 https://guides.rubygems.org/command-reference/#installupdate-options-2

 Signed-off-by: Pratik raj <rajpratik71@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 6, 2020

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@Rajpratik71 Rajpratik71 changed the title Ruby gem no doc tweak ARROW-9736 : [Ruby] gem no doc tweak Aug 14, 2020
@github-actions
Copy link

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

We don't recommend --no-document. We respect the default of the gem command.

(And we aren't using "--no-ri" nor "--no-rdoc".)

@kou kou closed this Aug 14, 2020
@Rajpratik71
Copy link
Contributor Author

using "--no-document" will help to reduce the size of docker image and no one reading the docs in docker environment

@kou
Copy link
Member

kou commented Aug 14, 2020

It's acceptable. Could you create a new JIRA issue and pull request that focus only for Docker images?

@Rajpratik71
Copy link
Contributor Author

It's acceptable. Could you create a new JIRA issue and pull request that focus only for Docker images?

Created fresh pull at #7964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants