ARROW-9743: [R] Sanitize paths in open_dataset #7960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealrichardson
force-pushed
the
r-dataset-path
branch
from
05f1a87
to
35d7364
Compare
nealrichardson
changed the title
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 17, 2020
Fixes problem of path expansion (`open_dataset("~/path")` now works). Unfortunately, tests can only write to tmp, so I can't add a test that confirms this, but I did verify locally.
Closes apache#7960 from nealrichardson/r-dataset-path
Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
kszucs
pushed a commit
to kszucs/arrow
that referenced
this pull request
Aug 17, 2020
Fixes problem of path expansion (`open_dataset("~/path")` now works). Unfortunately, tests can only write to tmp, so I can't add a test that confirms this, but I did verify locally.
Closes apache#7960 from nealrichardson/r-dataset-path
Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
Fixes problem of path expansion (`open_dataset("~/path")` now works). Unfortunately, tests can only write to tmp, so I can't add a test that confirms this, but I did verify locally.
Closes apache#7960 from nealrichardson/r-dataset-path
Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Fixes problem of path expansion (`open_dataset("~/path")` now works). Unfortunately, tests can only write to tmp, so I can't add a test that confirms this, but I did verify locally.
Closes apache#7960 from nealrichardson/r-dataset-path
Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem of path expansion (
open_dataset("~/path")now works). Unfortunately, tests can only write to tmp, so I can't add a test that confirms this, but I did verify locally.