ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512 #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple Clang cannot unzip "-march=skylake-avx512" exactly. Also fix AVX512 detect to include AVX512F,AVX512BW,AVX512VL,AVX512CD,AVX512DQ Signed-off-by: Frank Du <frank.du@intel.com>
|
@github-actions crossbow submit homebrew-cpp |
|
Revision: e500002 Submitted crossbow builds: ursa-labs/crossbow @ actions-500
|
|
homebrew-cpp is green now. Seems apple clang doesn't extract "-march=skylake-avx512" to "-mavx512f -mavx512cd -mavx512vl -mavx512dq -mavx512bw"。 |
pitrou
reviewed
Aug 28, 2020
pitrou
reviewed
Aug 28, 2020
Signed-off-by: Frank Du <frank.du@intel.com>
|
@github-actions crossbow submit homebrew-cpp |
|
Revision: e6a0aa6 Submitted crossbow builds: ursa-labs/crossbow @ actions-501
|
|
@github-actions crossbow submit homebrew-cpp |
|
Revision: 2d1c8a9 Submitted crossbow builds: ursa-labs/crossbow @ actions-502
|
nealrichardson
approved these changes
Aug 28, 2020
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
Apple Clang cannot unzip "-march=skylake-avx512" exactly. Also fix AVX512 detect to include AVX512F, AVX512BW, AVX512VL, AVX512CD, AVX512DQ Signed-off-by: Frank Du <frank.du@intel.com> Closes apache#8071 from jianxind/ARROW-9877 Authored-by: Frank Du <frank.du@intel.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Apple Clang cannot unzip "-march=skylake-avx512" exactly. Also fix AVX512 detect to include AVX512F, AVX512BW, AVX512VL, AVX512CD, AVX512DQ Signed-off-by: Frank Du <frank.du@intel.com> Closes apache#8071 from jianxind/ARROW-9877 Authored-by: Frank Du <frank.du@intel.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple Clang cannot unzip "-march=skylake-avx512" exactly.
Also fix AVX512 detect to include AVX512F, AVX512BW, AVX512VL, AVX512CD, AVX512DQ
Signed-off-by: Frank Du frank.du@intel.com