ARROW-9879: [Python] Add support for numpy scalars to ChunkedArray.__getitem__ #8072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/pyarrow/table.pxi
Outdated
Comment on lines
161
to
164
| elif isinstance(key, int): | ||
| return self.getitem(key) | ||
| elif np.isscalar(key) and np.issubdtype(key.dtype, np.integer): | ||
| return self.getitem(key) |
There was a problem hiding this comment.
Alternative is to do like array.pxi, and let python/cython handle the cast to integer (and let it raise error otherwise:
Suggested change
| elif isinstance(key, int): | |
| return self.getitem(key) | |
| elif np.isscalar(key) and np.issubdtype(key.dtype, np.integer): | |
| return self.getitem(key) | |
| return self.getitem(_normalize_index(key, self.chunked_array.length())) |
(minor downside is that the error message will only speak about "integer", and not "slice", but then anything convertible to int will be accepted automatically)
There was a problem hiding this comment.
Yes, we should probably use the same solution everywhere (and possibly avoid manual handling of Numpy scalars).
|
@xhochy do you have time to update this? |
|
Maybe Friday or Monday |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…getitem__ FYI @marc9595 Closes apache#8072 from xhochy/ARROW-9879 Lead-authored-by: Uwe L. Korn <uwelk@xhochy.com> Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @marc9595