Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions #8158

Closed
wants to merge 1 commit into from
Closed

ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions #8158

wants to merge 1 commit into from

Conversation

projjal
Copy link
Contributor

@projjal projjal commented Sep 10, 2020

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-7215

@projjal projjal force-pushed the castvarchar branch 8 times, most recently from eece673 to f1dbfbe Compare September 18, 2020 13:54
@projjal
Copy link
Contributor Author

projjal commented Oct 5, 2020

@wesm This pr fails in windows with a LINK error during build (during creating the unit test binary). Do you have an idea why this is failing in windows. Or is there any remote windows machine for arrow devs where I can try out and investigate myself (unfortunately I don't have a personal windows machine)?

@wesm
Copy link
Member

wesm commented Oct 7, 2020 

INK: command "C:\PROGRA~2\MIB055~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\gandiva-internals-test.rsp /out:release\gandiva-internals-test.exe /implib:release\gandiva-internals-test.lib /pdb:release\gandiva-internals-test.pdb /version:0.0 /machine:x64 /NODEFAULTLIB:LIBCMT /INCREMENTAL:NO /subsystem:console /MANIFEST /MANIFESTFILE:release\gandiva-internals-test.exe.manifest" failed (exit code 1120) with the following output:
LLVMSupport.lib(regcomp.c.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
unity_2_cxx.cxx.obj : error LNK2001: unresolved external symbol gdv_fn_castVARCHAR_int32_int64
unity_2_cxx.cxx.obj : error LNK2001: unresolved external symbol gdv_fn_castVARCHAR_int64_int64
unity_2_cxx.cxx.obj : error LNK2001: unresolved external symbol gdv_fn_castVARCHAR_float32_int64
unity_2_cxx.cxx.obj : error LNK2001: unresolved external symbol gdv_fn_castVARCHAR_float64_int64
release\gandiva-internals-test.exe : fatal error LNK1120: 4 unresolved externals

Either you need to statically-link these symbols (or include them with the .cc files / object code for the unit test) or add an appropriate export annotation for the functions so they will link from the DLL

@projjal projjal force-pushed the castvarchar branch 3 times, most recently from d5f4e32 to dc97693 Compare October 8, 2020 04:52
@projjal
Copy link
Contributor Author

projjal commented Oct 9, 2020

Thanks @wesm

@anthonylouisbsb anthonylouisbsb mentioned this pull request Mar 26, 2021
Closed
@projjal projjal closed this Mar 30, 2021
praveenbingo pushed a commit that referenced this pull request Apr 15, 2021
@anthonylouisbsb @projjal @praveenbingo
ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions
15137e2 
This PR implements the castVARCHAR for numeric values inside the Gandiva.

It replaces the logic of the #8158 PR  to change the function output to match the Java language patterns.

Closes #9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits:

7df55a5 <Anthony Louis> Apply formatting changes
7a724c0 <Anthony Louis> Remove unnecessary macros
4fb8a7f <Anthony Louis> Refactor if chain
e787051 <Anthony Louis> Add test to infinity case
b62b856 <Anthony Louis> Add comments for changes
cec11bb <Anthony Louis> Add tests to check Java compatibility
302139c <Anthony Louis> Add emit trailing point tests
efb94b9 <Anthony Louis> Add -0.0 inside cast test
523e60a <Anthony Louis> Add custom constructor inside the class
34f2f92 <Anthony Louis> Add class to print in formatted way
e244502 <Anthony Louis> Fix tests to consider java formatting
33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions

Lead-authored-by: Anthony Louis <anthony@simbioseventures.com>
Co-authored-by: Projjal Chanda <iam@pchanda.com>
Signed-off-by: Praveen <praveen@dremio.com>
projjal added a commit to projjal/arrow that referenced this pull request Apr 21, 2021
@anthonylouisbsb @projjal
ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions
b2e0cc9 
This PR implements the castVARCHAR for numeric values inside the Gandiva.

It replaces the logic of the apache#8158 PR  to change the function output to match the Java language patterns.

Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits:

7df55a5 <Anthony Louis> Apply formatting changes
7a724c0 <Anthony Louis> Remove unnecessary macros
4fb8a7f <Anthony Louis> Refactor if chain
e787051 <Anthony Louis> Add test to infinity case
b62b856 <Anthony Louis> Add comments for changes
cec11bb <Anthony Louis> Add tests to check Java compatibility
302139c <Anthony Louis> Add emit trailing point tests
efb94b9 <Anthony Louis> Add -0.0 inside cast test
523e60a <Anthony Louis> Add custom constructor inside the class
34f2f92 <Anthony Louis> Add class to print in formatted way
e244502 <Anthony Louis> Fix tests to consider java formatting
33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions

Lead-authored-by: Anthony Louis <anthony@simbioseventures.com>
Co-authored-by: Projjal Chanda <iam@pchanda.com>
Signed-off-by: Praveen <praveen@dremio.com>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@anthonylouisbsb @projjal @GeorgeAp
ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions
f3f5445 
This PR implements the castVARCHAR for numeric values inside the Gandiva.

It replaces the logic of the apache#8158 PR  to change the function output to match the Java language patterns.

Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits:

7df55a5 <Anthony Louis> Apply formatting changes
7a724c0 <Anthony Louis> Remove unnecessary macros
4fb8a7f <Anthony Louis> Refactor if chain
e787051 <Anthony Louis> Add test to infinity case
b62b856 <Anthony Louis> Add comments for changes
cec11bb <Anthony Louis> Add tests to check Java compatibility
302139c <Anthony Louis> Add emit trailing point tests
efb94b9 <Anthony Louis> Add -0.0 inside cast test
523e60a <Anthony Louis> Add custom constructor inside the class
34f2f92 <Anthony Louis> Add class to print in formatted way
e244502 <Anthony Louis> Fix tests to consider java formatting
33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions

Lead-authored-by: Anthony Louis <anthony@simbioseventures.com>
Co-authored-by: Projjal Chanda <iam@pchanda.com>
Signed-off-by: Praveen <praveen@dremio.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
@anthonylouisbsb @projjal @michalursa
ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions
95b2616 
This PR implements the castVARCHAR for numeric values inside the Gandiva.

It replaces the logic of the apache#8158 PR  to change the function output to match the Java language patterns.

Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits:

7df55a5 <Anthony Louis> Apply formatting changes
7a724c0 <Anthony Louis> Remove unnecessary macros
4fb8a7f <Anthony Louis> Refactor if chain
e787051 <Anthony Louis> Add test to infinity case
b62b856 <Anthony Louis> Add comments for changes
cec11bb <Anthony Louis> Add tests to check Java compatibility
302139c <Anthony Louis> Add emit trailing point tests
efb94b9 <Anthony Louis> Add -0.0 inside cast test
523e60a <Anthony Louis> Add custom constructor inside the class
34f2f92 <Anthony Louis> Add class to print in formatted way
e244502 <Anthony Louis> Fix tests to consider java formatting
33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions

Lead-authored-by: Anthony Louis <anthony@simbioseventures.com>
Co-authored-by: Projjal Chanda <iam@pchanda.com>
Signed-off-by: Praveen <praveen@dremio.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
@anthonylouisbsb @projjal @michalursa
ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions
04d0aff 
This PR implements the castVARCHAR for numeric values inside the Gandiva.

It replaces the logic of the apache#8158 PR  to change the function output to match the Java language patterns.

Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits:

7df55a5 <Anthony Louis> Apply formatting changes
7a724c0 <Anthony Louis> Remove unnecessary macros
4fb8a7f <Anthony Louis> Refactor if chain
e787051 <Anthony Louis> Add test to infinity case
b62b856 <Anthony Louis> Add comments for changes
cec11bb <Anthony Louis> Add tests to check Java compatibility
302139c <Anthony Louis> Add emit trailing point tests
efb94b9 <Anthony Louis> Add -0.0 inside cast test
523e60a <Anthony Louis> Add custom constructor inside the class
34f2f92 <Anthony Louis> Add class to print in formatted way
e244502 <Anthony Louis> Fix tests to consider java formatting
33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions

Lead-authored-by: Anthony Louis <anthony@simbioseventures.com>
Co-authored-by: Projjal Chanda <iam@pchanda.com>
Signed-off-by: Praveen <praveen@dremio.com>
@asfimport asfimport mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenbingo praveenbingo praveenbingo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@projjal @wesm @praveenbingo