ARROW-10003: [C++] Create parent dir for any destination fs in CopyFiles #8187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
commented
Sep 14, 2020
bkietz
commented
Sep 14, 2020
bkietz
force-pushed
the
10003-Create-directories-in-Cop
branch
3 times, most recently
from
4d0703c
to
4ad9abd
Compare
|
@pitrou CI failure seems unrelated, PTAL |
pitrou
reviewed
Sep 24, 2020
| } | ||
|
|
||
| std::vector<std::string> dirs(destination_dirs.size()); | ||
| std::move(destination_dirs.begin(), destination_dirs.end(), dirs.begin()); |
There was a problem hiding this comment.
Interesting, I didn't know this std::move override!
pitrou
reviewed
Sep 24, 2020
…systems in CopyFiles
bkietz
force-pushed
the
10003-Create-directories-in-Cop
branch
from
1430d19
to
6a8bd29
Compare
|
Non-Apache Travis: https://travis-ci.org/github/bkietz/arrow/builds/730077798 |
nealrichardson
added a commit
to nealrichardson/arrow
that referenced
this pull request
Sep 25, 2020
nealrichardson
added a commit
that referenced
this pull request
Sep 25, 2020
Somehow #8187 had a passing build but it didn't regenerate the R docs, so R builds are failing on master because the doc signature doesn't match the code. Closes #8277 from nealrichardson/fix-r Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
Previously only the parent directories of files to be copied to a different filesystem were created. Closes apache#8187 from bkietz/10003-Create-directories-in-Cop Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Oct 16, 2020
Somehow apache#8187 had a passing build but it didn't regenerate the R docs, so R builds are failing on master because the doc signature doesn't match the code. Closes apache#8277 from nealrichardson/fix-r Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Previously only the parent directories of files to be copied to a different filesystem were created. Closes apache#8187 from bkietz/10003-Create-directories-in-Cop Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Somehow apache#8187 had a passing build but it didn't regenerate the R docs, so R builds are failing on master because the doc signature doesn't match the code. Closes apache#8277 from nealrichardson/fix-r Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the parent directories of files to be copied to a different filesystem were created.